Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean /tmp after build #76

Closed
eljeko opened this issue May 30, 2017 · 1 comment
Closed

Clean /tmp after build #76

eljeko opened this issue May 30, 2017 · 1 comment

Comments

@eljeko
Copy link

eljeko commented May 30, 2017

It seems that

s2i/karaf/templates/s2i/assemble

doesn't clean the /tmp dir.

There is an option to delete the m2 (MAVEN_CLEAR_REPO=) but the /tmp dir contains also a ~/src with many files including the maven target dir with the .zip.

This makes the image to be ~two times bigger.

@vorburger
Copy link
Collaborator

@eljeko would this not break incremental builds? Or am I getting this wrong and sources are always freshly injected anyway? Or, if we did this, would we have to also save /tmp/src in s2i/save-artifacts?

If we do, then by default or as a new option? To be safe, perhaps best with a new option by env var, say S2I_CLEAR_SRC ?

BTW: Issue #12 is related to this - rather would not be needed, if we did this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants