Lock version of Jenkins slave used

[ALRubinger]

Introduced by #232

We have a line in our pipeline-template.yaml:

dockerImageRepository: openshiftio/launchpad-jenkins-slave

Um, how is k8s/OpenShift supposed to know that we want a particular version of the slave to be used? There are many tags under here; some are releases, some are just latest. How can we note in the template which version we want to be used?

@bparees Would you mind answering in the comments and I'll handle the work needed to make this happen? Thanks!

[bparees]

currently you can't, unfortunately. the logic was written before we got serious about imagestreams..for now i would strongly suggest you have your imagestream point to a repository that makes it clear what you want.

i'm planning to add annotation logic to support annotating/labeling a specific imagestreamtag instead of the imagestream, shortly.

the other thing you might be able to do, if imagestreams support it, is specify the full repository:tag in your dockerRepository field in your imagestream. I don't know offhand if they allow that or not, but if they do, it should result in the correct image value in the pod template:
https://github.com/openshift/jenkins/blob/master/2/contrib/jenkins/kube-slave-common.sh#L90

[ALRubinger]

Noted; for now our repo will only have latest tag, and we'll be careful about pushing stuff of unknown quality there.

Leaving this issue open to investigate your second option and see if that can lock us down.

[ALRubinger]

Thanks, @bparees . For the moment took your advice to only push to latest tag what we would consider releases, and it'll be the only tag in the Hub repo until we have a better way forward. Leaving open until we investigate more but this solution works enough for now. Real goal here is reproducible builds with locked version over time.

[quintesse]

We can probably close this now that we use S2I?