Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed KeyboardEvent.which in minor update #147

Closed
Freymaurer opened this issue Feb 6, 2025 · 3 comments
Closed

Removed KeyboardEvent.which in minor update #147

Freymaurer opened this issue Feb 6, 2025 · 3 comments

Comments

@Freymaurer
Copy link

Breaking change introduced in a minor update, resulting in error message when using nuget package in a new SAFE stack with a newer Fable.Browser.Dom version.

I know it is deprecated and i will replace it in my code, but i think it would be better to have set it as obsolete and remove it in a major change

client: .\output\fable_modules\Swate.Components.1.0.0-test.2\TermSearch\TermSearch.fs(847,40): (847,45) error FSHARP: The type 'KeyboardEvent' does not define the field, constructor or member 'which'. (code 39)
client: .\output\fable_modules\Swate.Components.1.0.0-test.2\TermSearch\TermSearch.fs(984,49): (984,54) error FSHARP: The type 'KeyboardEvent' does not define the field, constructor or member 'which'. (code 39)
@MangelMaxime
Copy link
Member

Oups...

I am not sure if we can do something about this one. What I mean is that it seems like I was not careful enough when crafting the releases and this is probably not the only breaking change I introduced in a minor version.

The ideal would be to revert the all the breaking changes, re-release a minor version and then re-apply the breaking change to a new major version.

But this feels like a lot of work...

Could you please use dynamic typing via the ? operator or update your code to not use a deprecated browser API?

I will be more careful in the future to enforce SemVer.

@Freymaurer
Copy link
Author

Yeah no worries. Just wanted to mention it 🙂

You can close the issue

@MangelMaxime
Copy link
Member

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants