Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SD Card implementation #48

Open
6 tasks
oscgonfer opened this issue Jul 27, 2023 · 1 comment
Open
6 tasks

SD Card implementation #48

oscgonfer opened this issue Jul 27, 2023 · 1 comment
Labels
core enhancement New feature or request

Comments

@oscgonfer
Copy link
Contributor

oscgonfer commented Jul 27, 2023

So the SD card library was upgraded in dev branch with refurbishment and new features. These issue is to map the overall status of this improvement, the sd-card library implementation and overall sd-card handling status.

Specially in sd-card (offline) mode it can lead to a warning or a more critical data loss if/when flash memory runs out.

This is also linked to the new CSV handling also included in that commit, which now has a "hash" check for the CSV header. This is done so that (dis)appearing sensors don't mess up with the current files. Also, there are some TODOs to consider in https://github.com/fablabbcn/smartcitizen-kit-21/blob/dev/sam/src/SckBase.cpp#L1252-L1253

In general, an overall review of the implementation with possible cases is necessary taking into account:

  • Check stability of the new library
  • Check implementation of csv header hash, naming...
    • Flash system and the particularity of old data posted after sd-card insertion (currently it doesn't check that data is saved in not a chronological order, but it works fine)
  • Check filesystem utils working OK (for instance to pipe the files to terminal output)
  • No wipe is implemented but that's fine for now. Good to have maybe for the future
  • In principle no other pending TODOs
@oscgonfer oscgonfer mentioned this issue Jul 27, 2023
11 tasks
@oscgonfer oscgonfer added core bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Jul 27, 2023
@oscgonfer
Copy link
Contributor Author

In principle this is more testing than anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant