You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello,
I've found your library useful, but encountered a bug recently. crossref.restful.Depositor has several methods that expect to pass the the attribute self.timeout as a parameter to self.do_http_request, which throws this error: "AttributeError: 'Depositor' object has no attribute 'timeout'" because self.timeout is never initialized.
I did a quick patch by adding timeout=100 to Depositor.__init__()'s parameter list and adding self.timeout = timeout in the body of the init, which fixed the issue, at least in my very cursory testing.
If the above is an acceptable solution, I'm happy to test it out more thoroughly and submit a pull request. If you'd prefer another approach, I'd be happy to help with that as well.
Thanks for creating and maintaining this library!
The text was updated successfully, but these errors were encountered:
Hello,
I've found your library useful, but encountered a bug recently.
crossref.restful.Depositor
has several methods that expect to pass the the attributeself.timeout
as a parameter toself.do_http_request
, which throws this error: "AttributeError: 'Depositor' object has no attribute 'timeout'" becauseself.timeout
is never initialized.I did a quick patch by adding
timeout=100
toDepositor.__init__()
's parameter list and addingself.timeout = timeout
in the body of the init, which fixed the issue, at least in my very cursory testing.If the above is an acceptable solution, I'm happy to test it out more thoroughly and submit a pull request. If you'd prefer another approach, I'd be happy to help with that as well.
Thanks for creating and maintaining this library!
The text was updated successfully, but these errors were encountered: