Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status-bar percents position inconsistency #2066

Open
MrAlaux opened this issue Dec 2, 2024 · 1 comment
Open

Status-bar percents position inconsistency #2066

MrAlaux opened this issue Dec 2, 2024 · 1 comment

Comments

@MrAlaux
Copy link
Collaborator

MrAlaux commented Dec 2, 2024

Tested in the latest master artifact (Win-64).

In Eviternity II, the health and armor percents are drawn shifted one pixel to the right in the latest master, compared to the 14.5.0 release:

comparison
(Ignore the color differences, that's just GIF compression.)

I thought this had something to do with the size of the percent glyph, but I tested FCFF which has an empty 1x1 percent glyph and it had no such issue, so I'm not sure. Either way, I'm afraid that whatever is causing this inconsistency in Evit2 could cause greater issues in other WADs.

@rfomin
Copy link
Collaborator

rfomin commented Dec 3, 2024

The "BigRed" font is supposed to be sbf_mono0 type, so each glyph should have a width of STTNUM0 patch or less. In Eviternity 2 (and Ancient Aliens, Valiant to name a few) STTPRCNT is 2px wider than STTNUM0. Anyway, we should draw this like vanilla, so I will revisit it after the bugfix release. The plan is to consolidate all font drawing functions (we have a lot of them).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants