Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSR-published package contains unnecessary files #972

Open
neoncitylights opened this issue Dec 11, 2024 · 1 comment · May be fixed by #973
Open

JSR-published package contains unnecessary files #972

neoncitylights opened this issue Dec 11, 2024 · 1 comment · May be fixed by #973
Assignees
@fabian-hiller
Labels
enhancement New feature or request question Further information is requested

Comments

@neoncitylights
Copy link

neoncitylights commented Dec 11, 2024 •
edited
Loading

Hi, thanks for making this package. :) I'm comparing the file contents of the package from how its published on NPM versus JSR, and on JSR it seems to contain a lot more files than needs be.

This fix though is easy as adding a publish.include field to jsr.json, see https://jsr.io/docs/package-configuration#include-and-exclude and https://jsr.io/docs/publishing-packages#filtering-files. Would be happy to write a PR

image image
neoncitylights added a commit to neoncitylights/valibot that referenced this issue Dec 11, 2024
@neoncitylights
Only include necessary files for JSR
587ee08 
To locally verify only the necessary files are included, you can run:
```sh
jsr publish --dry-run --allow-dirty
```

Fixes fabian-hiller#972
@neoncitylights neoncitylights linked a pull request Dec 11, 2024 that will close this issue
Open
@fabian-hiller
Copy link
Owner

Thank you! I added a comment to your PR.

@fabian-hiller fabian-hiller self-assigned this Dec 11, 2024
@fabian-hiller fabian-hiller added enhancement New feature or request question Further information is requested labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabian-hiller fabian-hiller

Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only include necessary files for JSR neoncitylights/valibot
2 participants
@neoncitylights @fabian-hiller