Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code block language mark #8

Open
KevinZonda opened this issue Mar 12, 2022 · 6 comments
Open

Code block language mark #8

KevinZonda opened this issue Mar 12, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@KevinZonda
Copy link
Contributor

Currently, the VuePress, GitHub & other platforms have no idea how to colour the code. So if we need the code syntax hightlight work, we could try to develop one js plugin, or we can use the keyword-similar language to alternate the fa in the code block (more likely to be C#?).

At least, we should NOT leave the code block's flag empty. It's not a good practice.

@KevinZonda
Copy link
Contributor Author

/cc @Cubik65536

@Cubik65536
Copy link
Member

We'll look into it.

@Cubik65536 Cubik65536 self-assigned this Mar 12, 2022
@Cubik65536 Cubik65536 added the enhancement New feature or request label Mar 12, 2022
@Cubik65536
Copy link
Member

I think this can be done with Prism's documentation about defining a new language.

Don't know if you want to try to implement this in our docs.

@fawdlstty
Copy link
Member

  1. Github official syntax highlighting requires more than 200 repositories to use this language, and then give pr to the highlighted project
  2. The grammar is not completely determined, and there are great differences between fa and existing languages

For two reasons, I suggest ignoring the question for now. After github approves it, we can modify it in a unified manner.

@Cubik65536 Cubik65536 pinned this issue Mar 13, 2022
@Cubik65536
Copy link
Member

Cubik65536 commented Mar 13, 2022

(Edit after a discussion about this project)

For the documentation, every code block in the markdown will still be written as ``` fa ```.

And all the code coloring jobs will be done once the language's grammar is completely determined.

@Cubik65536
Copy link
Member

Pinned and left it open because this is long-term work to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants