Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple XY components and Svelte 5 #379

Open
Magnus-Ignitic opened this issue Apr 30, 2024 · 5 comments
Open

Multiple XY components and Svelte 5 #379

Magnus-Ignitic opened this issue Apr 30, 2024 · 5 comments

Comments

@Magnus-Ignitic
Copy link

I know Svelte 5 is still in RC but interesting finding(?) nonetheless. Or Not. Multiple XY components in the XY container crashes my application at least:

<VisXYContainer
  {data}
  margin={{ left: 5, right: 5, top: 5, bottom: 5 }}
  height="100"
>
  <VisLine {x} {y} lineWidth={2} color="#80808080" />
  <!-- This line causes browser to freeze -->
  <!-- <VisLine {x} y={y1} lineWidth={3} color="#ff00ff" /> -->
</VisXYContainer>

Same code works in Svelte 4.

@hewliyang
Copy link

Any updates on Svelte 5 support? Seems that an example like this just causes an out of memory error on the browser

@lee00678
Copy link
Collaborator

lee00678 commented Nov 7, 2024

@hewliyang @Magnus-Ignitic, thanks for bringing this up. We are looking into this issue. Hopefully we can include a fix in our next release.

@david-plugge
Copy link

Just ran into this aswell, the browser just freezes. Looking forward for a solution and thank you for this awesome library!

@xmlking
Copy link

xmlking commented Nov 17, 2024

browser freeze with chunk-SXMMSZKG.js?v=7191c123:303 Uncaught (in promise) Error: effect_update_depth_exceeded error

image

@lee00678
Copy link
Collaborator

lee00678 commented Nov 20, 2024

@xmlking @david-plugge @hewliyang @Magnus-Ignitic
Just release a beta version for the Svelte 5 fix 1.5.0-beta.3. Please feel free to test it out, and let us know if there is anything we've missed. Link #484

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants