Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--camera-index should override other camera options #1638

Open
mwestphal opened this issue Sep 27, 2024 · 2 comments
Open

--camera-index should override other camera options #1638

mwestphal opened this issue Sep 27, 2024 · 2 comments
Assignees
Labels
good first issue Good for newcomers hacktoberfest help wanted Please help with this issue! source:F3DApplication type:bug Something isn't working

Comments

@mwestphal
Copy link
Contributor

mwestphal commented Sep 27, 2024

Describe the bug
F3D has many camera option but there is one that rely on camera provided by the file, however it should override other camera options but it does not

To Reproduce
Steps to reproduce the behavior:

  1. Open the file using f3d --dry-run Cameras.gltf --camera-index=0 --camera-position=0,0,0
  2. Camera should be positioned correctly but it is not

Expected behavior
Camera positioned as if camera-position was not provided

Additional context
In F3DStarter.cxx:1075, SetupCamera is always called. It should only be called if camera-index has no value, as its an std::optional

Also a test should be added.

@mwestphal mwestphal added type:bug Something isn't working good first issue Good for newcomers help wanted Please help with this issue! source:F3DApplication hacktoberfest labels Sep 27, 2024
@dk1242
Copy link
Contributor

dk1242 commented Sep 27, 2024

Hi,
I want to work on this issue.

@mwestphal
Copy link
Contributor Author

Of course, I just assigned it to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest help wanted Please help with this issue! source:F3DApplication type:bug Something isn't working
Projects
Status: To do
Development

No branches or pull requests

2 participants