Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-API calls to R error in R-devel #226

Closed
eitsupi opened this issue Apr 22, 2024 · 4 comments
Closed

non-API calls to R error in R-devel #226

eitsupi opened this issue Apr 22, 2024 · 4 comments

Comments

@eitsupi
Copy link
Contributor

eitsupi commented Apr 22, 2024

Today R CMD check for R-devel (2024-04-21 r86458) started getting errors in https://github.com/pola-rs/r-polars.
For example:

File 'polars/libs/x64/polars.dll':
  Found non-API calls to R: 'SET_ENCLOS', 'SET_ENVFLAGS', 'SET_PRCODE',
    'SET_PRENV', 'SET_PRVALUE'

Compiled code should not call non-API entry points in R.

See 'Writing portable packages' in the 'Writing R Extensions' manual.

https://github.com/pola-rs/r-polars/actions/runs/8779929721/job/24088871293#step:11:45

Maybe related to https://developer.r-project.org/blosxom.cgi/R-devel/NEWS/2024/04/21#n2024-04-21

@CGMossa
Copy link
Member

CGMossa commented Apr 22, 2024

Yes! These are new. Usually, our very own @yutannihilation is on top of these when they come up.
They are not located in one place only in the api.
Hopefully, we'll get a hold on this soon.

@yutannihilation
Copy link
Contributor

Could you try running this action?

https://github.com/extendr/libR-sys/actions/workflows/non-api-call.yml

@yutannihilation
Copy link
Contributor

Wow, a lot!

https://github.com/extendr/libR-sys/pull/227/files

@CGMossa
Copy link
Member

CGMossa commented Jun 10, 2024

Can I close this? I think we've dealt with this now, right?

@CGMossa CGMossa closed this as completed Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants