Make C-enums into idiomatic rust enums #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
/bindings |
|
Hm, should we already bump |
|
Sure. Please make a PR that bumps the version. |
|
Checking my comments, I do not get it why can't we mark this as |
CGMossa
force-pushed
the
convert_to_rust_enums
branch
from
1c27f85 to
545f970
Compare
|
Bumped version. |
Hard to remember.. I guess I saw that you'd make separate PRs to bump the version in rextendr. And I asked you to do it here maybe because I thought it was more elaborate than just changing a file. |
Ilia-Kosenkov
approved these changes
Apr 21, 2024
CGMossa
force-pushed
the
convert_to_rust_enums
branch
from
545f970 to
e92a45a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several "inferred" enums in the R-API. This setting ensures that
they become idiomatic Rust enums.
There are still missing ones, namely the macro-defined-enums, but maybe I'll add those somewhere else.