-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Href<T> breaks type checking on CI #746
Comments
Same here :( |
Same |
I've used a workaround of running - name: ʦ Generate mobile router types
run: timeout 10 pnpm start
working-directory: apps/mobile
continue-on-error: true This could be quite brittle but works for now. Replace |
Also looking for a good solution for this. My current workaround is to add .expo/*
!.expo/types/ |
@robertherber ’s fix is a nice temporary solution. |
It seems there is now a command to generate the types on demand. From the docs here:
Which would solve OP's issue (and mine) but the command doesn't seem to work for me at least. I'm getting the following error:
What am I doing wrong? Related issue: expo/expo#24818 |
For folks following along, the related issue has now been fixed & now you can use |
@johnjensenish we can still repro this error in expo v50 even after running the "expo": "~50.0.14",
"expo-router": "3.4.8",
"react-native": "0.73.6", @robertherber 's solution is still a viable workaround. |
Getting this with expo router Href and Route types |
works for me "expo": "~51.0.22",
"expo-router": "~3.5.18", run |
Which package manager are you using? (Yarn is recommended)
yarn
Summary
👋 Not sure if this is a bug or a feature request...
We have a basic
yarn tsc
check runnning on CI for pull requests, which fails on TypeScript errors. If try to use theHref<T>
type, the CI pipeline breaks, because these types are dynamically generated.Is there a way to generate these dynamic types on CI?
Minimal reproducible example
Simple example:
The text was updated successfully, but these errors were encountered: