Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android converted to semver despite configs & iOS removes leading zeros in semver #18

Open
kungfuchicken opened this issue Sep 21, 2020 · 2 comments · Fixed by absolute-version/commit-and-tag-version#11 · May be fixed by conventional-changelog/standard-version#670
Labels
bug Something isn't working

Comments

@kungfuchicken
Copy link

Description of the bug

Android version is bumped to semver instead of default android method.
iOS version does not respect leading zeros.

To Reproduce

installed and configured per documentation using 1.0.3

configure

// .versionrc.js

module.exports = {
  bumpFiles: [
    {
      filename: 'package.json',
    },
    {
      filename: 'app.json',
      updater: require.resolve('standard-version-expo'),
    },
    {
      filename: 'app.json',
      updater: require.resolve('standard-version-expo/android'),
    },
    {
      filename: 'app.json',
      updater: require.resolve('standard-version-expo/ios'),
    }
  ]
};

run

% npx standard-version --dry-run 
✔ bumping version in package.json from 2.2.4 to 2.2.5
✔ bumping version in app.json from 2.2.4 to 2.2.5
✔ bumping version in app.json from 380020204 to 2.2.5
✔ bumping version in app.json from 2.2.04 to 2.2.5
✔ outputting changes to CHANGELOG.md

---
### 2.2.5 (2020-09-21)
---

✔ committing app.json and package.json and CHANGELOG.md
✔ tagging release v2.2.5
ℹ Run `git push --follow-tags origin CU-buh9bc-trunk-based-ci-cd` to publish

Expected behavior

android would bump to 380020204
iOS would bump to 2.2.05

Actual behavior

android bumpe to 2.2.5
iOS bumped to 2.2.5

@kungfuchicken kungfuchicken added the bug Something isn't working label Sep 21, 2020
@kungfuchicken
Copy link
Author

oof... just saw this #10 and verified it's the same issue for me. 🤦🏻 . would still be nice to have higher visibilty to "just ignore dry-run output" and/or an actual fix so the output displays correctly.

@brettdh
Copy link

brettdh commented Dec 31, 2020

Forgot to mention, but I opened a PR on standard-version to fix the underlying issue: conventional-changelog/standard-version#670

It has been sitting for a while, though. Just rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants