Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version for smart_open dependency #81

Closed
BLKSerene opened this issue Feb 27, 2024 · 3 comments · Fixed by #84
Closed

Bump version for smart_open dependency #81

BLKSerene opened this issue Feb 27, 2024 · 3 comments · Fixed by #84
Labels
enhancement New feature or request

Comments

@BLKSerene
Copy link

Hi, smart_open 7.0.1 has been released, are there any plans to support the new version? And the same for that dependency in spaCy.
@svlandeg
Copy link
Member

Yes, we'll look into supporting the new version. Are there any breaking changes from 7.0.0 onwards, as far as you know? If you use weasel or spacy in an environment where you've already upgraded smart_open to the latest version, do you see any issues other than perhaps pip complaining about a potential conflict?

@svlandeg svlandeg added the enhancement New feature or request label Feb 29, 2024
@BLKSerene
Copy link
Author

Since I don't use the project functionalities in spaCy or weasel directly, everything seems to be working fine with the latest smart_open.

@svlandeg
Copy link
Member

Thanks for the confirmation! We'll get this pin updated.

@svlandeg svlandeg linked a pull request Mar 22, 2024 that will close this issue
Update smart_open pin to include v7.x #84
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update smart_open pin to include v7.x svlandeg/weasel
2 participants
@svlandeg @BLKSerene