-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a "reset" option (with "Are you Sure?") #21
Comments
I can add a "reset" button but I am not sure that it should reset the database. As for me it will be much handy if this button removes all statements, all variables, disjoins, and description. But leaves currently loaded database untouched. Changing the database is very simple - click it (I mean click the header) and it will be expanded, then according to what you need either press the "trash can" button, or change the scope and label, add new sources if needed. Then press "Apply changes". The reason why I think it doesn't make sense to reset the database is how I imaging a usual workflow - load a database, create a proof; delete the proof, create another proof; an so on. With resetting the database users will be forced to load a database again after creating each proof. |
Okay, that makes sense! Maybe "Are you sure?" dialogue can make that clear. Something like this:
|
BTW, I've worked out a simple solution in the editor: use loading. E.g.: |
Unfortunately this will not work in the next version. Just try to replace TEMP mode is read-only. Any change you do in TEMP mode is not saved and will be lost when you close a browser tab with it. This relates to both changes in the editor and in the settings. Currently there is no easy way how to move from TEMP mode to NORMAL mode. The only way is to 1) use I will add a warning for users when they start editing in TEMP mode, reminding that all their changes will not be saved in this mode. |
A warning about editing in TEMP mode is implemented on dev. Open mm-lamp on dev by some URL with editorState and try to edit anything in the editor - you will see this warning. |
Can you tell me more about TEMP mode? What is different about TEMP mode? How do you enter and leave it? |
Also, what indicates TEMP mode? Just the browser header? The browser header is not normally shown on Firefox on Android, and I don't think it's shown on Macs either. |
Ah!! Now I see it when I try to edit an existing statement:
However, I don't see this warning when I press "+" (add statement). Shouldn't this warning also show up the first time you use any modification like add, duplicate, search, replace, renumber? It looks like "TEMP mode" is forcibly enabled when you load from a URL, correct? That's a little unfortunate for me, because for a tutorial it's nice to be able to reload a specific known state. It'd be nice if there was a way for the URL to say "use this as the real thing" (presumably requiring user confirmation first). I like the idea of a TEMP mode though. I've drafted guide text to explain this, see the URL below. |
My attempt to explain TEMP mode is here, please correct as needed: |
Related: #114 |
You've understood it correctly.
For now yes. But I will improve it in scope of #117
You are right, I missed these cases. I will handle them too. Thanks for pointing this out.
Correct, that's how it works now. I implemented TEMP mode even before your first PR in this repo, I didn't expect this need :) Let's discuss this in the corresponding issue you've created #114 |
Absolutely! My goal right now is to document it correctly & file issues for my ideas on how I think it could be improved in the future. |
The "Reset editor content" menu item in the hamburger menu is available on dev. There is no "Are you sure?" because users can use the undo/redo feature. |
Great!! Omitting "are you sure", because of undo/redo, is just fine. Having undo eliminates all sorts of problems :-). |
This is available in version 16 |
Once you're done with a proof, it's not clear how to restart from scratch. You can select and delete all the statements, but that doesn't load a different database. It'd be nice to have a "reset" button, which of course would ask for confirmation (default NO) before erasing everything.
The text was updated successfully, but these errors were encountered: