Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object save method is inserting extra "." in filename #1197

Open
rbyh opened this issue Oct 28, 2024 · 6 comments
Open

Object save method is inserting extra "." in filename #1197

rbyh opened this issue Oct 28, 2024 · 6 comments
Assignees

Comments

@rbyh
Copy link
Contributor

rbyh commented Oct 28, 2024

image

https://www.expectedparrot.com/content/5a22112b-80ef-4a47-873a-e27ccee55d7b

@johnjosephhorton
Copy link
Contributor

Ah - so I think what I had intended was that the user would save without the extension:
Screenshot 2024-10-28 at 6 56 55 AM
But it would work if they added the extension manually. But I don't think that's great (and obviously I'm screwing up the string).
A few thoughts:

  1. It is good that "json.gz" tells you what it is (compressed json), but that makes it more complex and makes it hard for the user to remember. I wrote it and I couldn't remember.
  2. We could save everything as "your_object.edsl" or "your_object.ep" which would me less clear what it is but more clear that it was something EP created
  3. It would be good to have a "universal load" - maybe obj = edsl.load('my_thing.ep') and will get it right
  4. It would nice if this all worked seamlessly with coop as a backup / alt location
  5. It should probably work well w/o a name e.g., my_object.save() does something sensible like look through the directory is increments the object count as needed to store it as "my_object_2.ep`

@rbyh
Copy link
Contributor Author

rbyh commented Oct 28, 2024

My preference would be to allow the user to drop or include the extension. I would not use something unexpected eg ".edsl".

@rbyh
Copy link
Contributor Author

rbyh commented Oct 28, 2024

Method is also missing for Model (but not ModelList):
image

@johnjosephhorton
Copy link
Contributor

Consider that if you save a word document, you aren't asked to remember it's "docx"

@johnjosephhorton
Copy link
Contributor

re: Model - good catch. This is because Model is not actually a Base object - it's a like a cut-out for LanguageModel. I'll add this method!

@rbyh
Copy link
Contributor Author

rbyh commented Oct 28, 2024

Exactly re docx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants