Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vulcan_cfg variables not defined or not used in the cfg files #15

Open
OrelSto opened this issue Dec 5, 2024 · 0 comments
Open

vulcan_cfg variables not defined or not used in the cfg files #15

OrelSto opened this issue Dec 5, 2024 · 0 comments

Comments

@OrelSto
Copy link

OrelSto commented Dec 5, 2024

Hi,
I have a short list of variable used in the code but not present in the vulcan_cfg file (HDs, Earth and Jupiter)
use_ini_cold_trap
fix_species_from_coldtrap_lev
stop_conden_time
and the next one is defined but not used in the code
fix_species_time
It is said in the comments of post_conden_rtol that post_conden_rtol is set up after fix_species_time but this not appear in the code.
we use post_conden_rtol with the condition:
if vulcan_cfg.fix_species and var.t > vulcan_cfg.stop_conden_time:
So maybe stop_conden_time is a new name for fix_species_time?

Running HD189 example works with the cfg provided

Running Jupiter example does not work with the cfg provided:
atm_file = 'atm/Jupiter_vz_up_vtop5.txt' is missing
replacing it by atm_file = 'atm/Jupiter_deep_top.txt'
variables described above are still missing in the cfg file

Running HD209 example does not work with the cfg provided:
variables described above are still missing in the cfg file
use_lowT_limit_rates is not set up in the cfg file example
setting use_lowT_limit_rates = False in cfg file => HD209 example runs

Running Earth example does not work with the cfg provided:
File "/VULCAN/make_chem_funs.py", line 725, in check_conserv
compo_row = [sp.decode("utf-8") for sp in compo_row]
^^^^^^^^^
AttributeError: 'numpy.str_' object has no attribute 'decode'. Did you mean: 'encode'?

Maybe an error with numpy version?

File "/VULCAN/build_atm.py", line 195, in ini_y
y_ini[:,species.index(sp)] = gas_tot* vulcan_cfg.const_mix[sp] # this also changes data_var.y
ValueError: 'Ar' is not in list
variables described above are still missing in the cfg file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant