Show URL of currently selected bookmark #16 #18
Conversation
See also exhuma#17
There was a problem hiding this comment.
The changes look good. Just a couple of microscopic changes, and in addition to the small comments about the code, I would retarget this to merge into develop instead of master. It seems I have forgotten to set develop as default branch target. I will do this immediately :)
| @@ -101,13 +101,24 @@ class Link extends LitElement { | |||
| }; | |||
| } | |||
|
|
|||
| onMouseEvent(text: string) { | |||
There was a problem hiding this comment.
I would rename this to something else because it is not only happening on mouse events. Something like dispatchFocusChange or dispatchTitleChange.
|
You know what, the changes are super small, I'll quickly fix those myself 😄 |
|
I pushed the new branch issue-16-integration with a minor change. The change ensures that the "status bar" also shows up properly when using the code as a browser extension. There's one issue though: The "focus" event is not firing when using the keyboard for navigation. To reproduce, focus the quicksearch text field and use the arrow-up/down keys. Could you have a look at that please? As a pointer, look at this piece which deals with the keyboard navigation: |
|
I forgot to mention: The new branch is rebased onto |
|
I am not sure if i did everything right, but i've:
It should be working now correctly under all conditions (mouse hover, tab focus and keyboard control). If you find anything wrong or a need of change, let me know. PS: sorry again for not responding sooner, i'll be here daily if you need any more changes |
Hello, sending the PR.
Resolves #16