Skip to content

Commit e502aa6

Browse files
authored
Merge pull request #210 from macta/fix-context-menu-experiment
Remove the experimental ability to fetch a new exercise from the classes pan…
2 parents 3764869 + 5da7868 commit e502aa6

File tree

8 files changed

+21
-27
lines changed

8 files changed

+21
-27
lines changed

dev/src/ExercismTools/ClyExercismFetchCommand.class.st

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -7,27 +7,9 @@ Class {
77
#category : #'ExercismTools-Menus'
88
}
99

10-
{ #category : #activation }
11-
ClyExercismFetchCommand class >> classListMenuActivation [
12-
<classAnnotation>
13-
14-
^CmdContextMenuActivation byRootGroupItemOrder: 3 for: ClyClassContextOfFullBrowser
15-
]
16-
1710
{ #category : #activation }
1811
ClyExercismFetchCommand class >> contextMenuOrder [
19-
^10
20-
]
21-
22-
{ #category : #activation }
23-
ClyExercismFetchCommand class >> isExercismTagIn: aToolContext [
24-
25-
(aToolContext isKindOf: ClyClassContextOfFullBrowser) ifFalse: [ ^super isExercismTagIn: aToolContext ].
26-
27-
aToolContext selectedItems isEmpty and: [ aToolContext selectedPackageItems do: [:any |
28-
^ any browserItem name = ExercismManager exercismPackageName ]].
29-
30-
^false
12+
^5
3113
]
3214

3315
{ #category : #activation }

dev/src/ExercismTools/ClyExercismSubmitCommand.class.st

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ Class {
99

1010
{ #category : #activation }
1111
ClyExercismSubmitCommand class >> contextMenuOrder [
12-
^1
12+
^10
1313
]
1414

1515
{ #category : #accessing }

docs/ABOUT.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,13 @@ Welcome to [Pharo](http://www.pharo.org), an environment and language that embra
33
It features a world that is:
44

55
- **Simple and Powerful:** No constructors, type declarations, interfaces and primitive types. Yet it's a powerful and elegant language with a full syntax that fits on a [postcard](https://en.wikipedia.org/wiki/File:Pharo_syntax_postcard.svg)! The magic is objects and messages all the way down.
6+
67
- **Live and Immersive:** Immediate feedback at any moment of your development: Developing, testing, exploring, debugging. Even in live environments, you don't have to wait to compile and deploy!
8+
79
- **Amazing for Debugging:** The [debugger](https://medium.com/@richardeng/how-to-use-the-pharo-debugger-eb554a2950b6) is unlike anything you've seen before. While it lets you step through code, you can also restart execution at any point, create methods and classes on the fly, extend its abilities, and much more!
10+
811
- **Rich in History but Forward Looking:** Many concepts originated from Smalltalk: [MVC](http://heim.ifi.uio.no/~trygver/themes/mvc/mvc-index.html), [JIT](https://www.wikiwand.com/en/Just-in-time_compilation) compilation, Live coding, [TDD](https://en.wikipedia.org/wiki/SUnit), [Refactoring](http://www.academia.edu/10644191/A_Refactoring_Tool_for_Smalltalk) and many more. However we are still looking ahead with [moldable tools](https://gtoolkit.com/), [GtSpotter](http://www.humane-assessment.com/blog/introducing-gtspotter), [Agile Visualisation](http://agilevisualization.com/), and [MetaLinks](https://www.slideshare.net/MarcusDenker/lecture-metalinks) to name a few...
12+
913
- **Active, Friendly, Helpful Community:** Pharo is yours, made by an incredible [community](http://pharo.org/community), with more than 100 contributors on the last revision and many more constantly [contributing](http://pharo.org/contribute) with frameworks, libraries and advice.
1014

1115
Still not convinced? Smalltalk has a rich and fascinating [history](http://worrydream.com/EarlyHistoryOfSmalltalk/), that has influenced most of today's languages and techniques in one form or another. [Learning the source](https://twitter.com/dhh/status/950145591379742727) of these ideas is the road to being a good programmer in any language. But most of all, its just incredibly fun! Why not join in?

docs/INSTALLATION.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ and then initally launch Pharo and the exercism tools by typing:
1616
./pharo-ui Pharo.image eval "
1717
Metacello new
1818
baseline: 'Exercism';
19-
repository: 'github://exercism/pharo-smalltalk:v0.2.2';
19+
repository: 'github://exercism/pharo-smalltalk:v0.2.3';
2020
load.
2121
#ExercismManager asClass welcome.
2222
"
@@ -66,7 +66,7 @@ Finally, copy and paste the following snippet into the playground:
6666
```smalltalk
6767
Metacello new
6868
baseline: 'Exercism';
69-
repository: 'github://exercism/pharo-smalltalk:v0.2.2';
69+
repository: 'github://exercism/pharo-smalltalk:v0.2.3';
7070
load.
7171
7272
#ExercismManager asClass welcome.

exercises/grade-school/.meta/hints.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
It isn't strictly necessary to model students as a seperate object, you can use a convenient internal data strcture as long as it doesn't leak out into the results.Note: this exercise has been slightly modified from problem-specification, as it makes more sense to seperate adding students and querying them in seperate methods (vs. having one method doing both, which feels less Pharo/Smalltalk like).
1+
It isn't strictly necessary to model students as a seperate object, you can use a convenient internal data strcture as the requirements are quite simple (and as long as it doesn't leak out into the results).Note: this exercise has been slightly modified from the problem-specification, as it makes more sense to seperate adding students and querying them in seperate methods (vs. having one method doing both, which feels less Pharo/Smalltalk like).

exercises/grade-school/.meta/solution/GradeSchool.class.st

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ GradeSchool >> addStudents: aCollection [
3838

3939
{ #category : #exercism }
4040
GradeSchool >> desiredGrade: gradeInteger [
41-
"Anser the Collection of students filtered by grade, alphabetically"
41+
"Answer the Collection of students filtered by grade, alphabetically"
4242

4343
^ self
4444
formatResult:

exercises/grade-school/GradeSchoolTest.class.st

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,9 @@ experiment make the code better? Worse? Did you learn anything from it?
3737
3838
## Hint
3939
40-
It isn't strictly necessary to model students as a seperate object, you can use a convenient internal data strcture as long as it doesn't leak out into the results.
40+
It isn't strictly necessary to model students as a seperate object, you can use a convenient internal data strcture as the requirements are quite simple (and as long as it doesn't leak out into the results).
4141
42-
Note: this exercise has been slightly modified from problem-specification, as it makes more sense to seperate adding students and querying them in seperate methods (vs. having one method doing both, which feels less Pharo/Smalltalk like).
42+
Note: this exercise has been slightly modified from the problem-specification, as it makes more sense to seperate adding students and querying them in seperate methods (vs. having one method doing both, which feels less Pharo/Smalltalk like).
4343
4444
"
4545
Class {
@@ -64,6 +64,14 @@ GradeSchoolTest class >> exercise [
6464

6565
]
6666

67+
{ #category : #generator }
68+
GradeSchoolTest class >> generator [
69+
"Potential generator hints"
70+
71+
^ {('rosterStudents:' -> #('addStudents:' 'roster')).
72+
('gradeStudents:desiredGrade:' -> #('addStudents:' 'desiredGrade:'))}
73+
]
74+
6775
{ #category : #config }
6876
GradeSchoolTest class >> uuid [
6977
"Answer a unique id for this exercise"

exercises/grade-school/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ experiment make the code better? Worse? Did you learn anything from it?
3636

3737
## Hint
3838

39-
It isn't strictly necessary to model students as a seperate object, you can use a convenient internal data strcture as long as it doesn't leak out into the results.Note: this exercise has been slightly modified from problem-specification, as it makes more sense to seperate adding students and querying them in seperate methods (vs. having one method doing both, which feels less Pharo/Smalltalk like).
39+
It isn't strictly necessary to model students as a seperate object, you can use a convenient internal data strcture as the requirements are quite simple (and as long as it doesn't leak out into the results).Note: this exercise has been slightly modified from the problem-specification, as it makes more sense to seperate adding students and querying them in seperate methods (vs. having one method doing both, which feels less Pharo/Smalltalk like).
4040

4141

4242
## Downloading

0 commit comments

Comments
 (0)