Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip all types of tests #33

Closed
ErikSchierboom opened this issue Oct 1, 2021 · 1 comment · Fixed by #53
Closed

Unskip all types of tests #33

ErikSchierboom opened this issue Oct 1, 2021 · 1 comment · Fixed by #53
Labels
x:action/fix Fix an issue x:knowledge/none No existing Exercism knowledge required x:module/test-runner Work on Test Runners x:size/large Large amount of work x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises)

Comments

@ErikSchierboom
Copy link
Member

Ensures that all Skip properties are removed, regardless of the type of attribute. Without this, the diamond exercise's tests won't be unskipped (they use property-based testing).

See exercism/csharp-test-runner#67 for the C# equivalent PR.
@ErikSchierboom ErikSchierboom added x:action/fix Fix an issue x:knowledge/none No existing Exercism knowledge required x:module/test-runner Work on Test Runners x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises) x:size/large Large amount of work labels Oct 1, 2021
@ErikSchierboom ErikSchierboom mentioned this issue Nov 12, 2021
Closed
@martinfreedman
Copy link

I will look into this as we are following in the PR1029.

@ErikSchierboom ErikSchierboom mentioned this issue Nov 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
x:action/fix Fix an issue x:knowledge/none No existing Exercism knowledge required x:module/test-runner Work on Test Runners x:size/large Large amount of work x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve unskipping support exercism/fsharp-test-runner
2 participants
@ErikSchierboom @martinfreedman