Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bracket-push: renamed to matching-brackets #385

Closed
4 tasks
petertseng opened this issue Apr 22, 2019 · 2 comments
Closed
4 tasks

bracket-push: renamed to matching-brackets #385

petertseng opened this issue Apr 22, 2019 · 2 comments

Comments

@petertseng
Copy link
Member

petertseng commented Apr 22, 2019

In exercism/problem-specifications#1501, bracket-push was renamed to matching-brackets in problem-specifications, therefore it is recommended that this track (which has the bracket-push exercise) also renames it.

The reasons for this recommendation:

  • to name the exercise by its story, not by what it potentially teaches
  • to avoid unnecessarily biasing the solution space

If this track decides to follow this recommendation, here are some things that may need a change:

  • config.json (change the slug of the exercise; no need to change its uuid)
  • name of the directory
  • README (contains the name of the exercise)
  • code

If you're not sure what needs to change, feel free to examine PRs to other tracks by looking at any PRs linked to exercism/problem-specifications#1501.

When the rename is complete, the person who did the rename should close this issue; you don't need to ask for confirmation from the person who filed this issue (the person who filed this issue might not check back regularly).

If this track instead decides that accepting this recommendation is a bad idea for the track, then this issue should be closed upon making that decision, and none of the above steps should be taken.


Checklist (added by @NobbZ)

@NobbZ
Copy link
Member

NobbZ commented Apr 23, 2019

Yes, following the rename is a good thing. I'll prepare a checklist later today.

@NobbZ
Copy link
Member

NobbZ commented Jun 29, 2019

I took a closer look, and as bracket-push is generated by the testgen, I need to tackle this one as when I do the next canonical data update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants