Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grains error message should be updated #60

Closed
BNAndras opened this issue Sep 17, 2024 · 0 comments · Fixed by #67
Closed

grains error message should be updated #60

BNAndras opened this issue Sep 17, 2024 · 0 comments · Fixed by #67
Assignees

Comments

@BNAndras
Copy link
Member

Batch only works up to square 31 per the test suite comments. The expected error message for a square below 1 or above 64 is "square must be between 1 and 64", but no square above 31 would work. A more appropriate error message might be "square must be between 1 and 31".

Also we may want an instructions.append.md to highlight that Batch can only go up to square 31 so the tests have been tweaked around that. Then the students are aware of this limitation going in so there'll hopefully be less frustration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants