Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope of tabs is visually unclear #173

Open
timhoffm opened this issue Dec 4, 2023 · 2 comments
Open

Scope of tabs is visually unclear #173

timhoffm opened this issue Dec 4, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@timhoffm
Copy link

timhoffm commented Dec 4, 2023

Context

The tab content is only bounded by a top and bottom line. It's difficult to associate the bottom line with the end of the tab area.

Example: https://matplotlib.org/stable/devel/development_setup.html#create-a-dedicated-environment

grafik

Proposal

The tab scope should be visually more clear.

I suggest to draw a full box, e.g.

grafik

which I generated using the (not necessarily best) CSS:

  border-left: 0.0625rem solid var(--sd-color-tabs-underline);
  padding-left: 0.5rem;
  border-right: 0.0625rem solid var(--sd-color-tabs-underline);
  padding-right: 0.5rem;

Alternatively, one could add a background color to the tab content, but this may make consistent color styling harder.

Tasks and updates

No response

@timhoffm timhoffm added the enhancement New feature or request label Dec 4, 2023
Copy link

welcome bot commented Dec 4, 2023

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

@timhoffm
Copy link
Author

timhoffm commented Jun 5, 2024

Related: pydata-sphinx-theme has added styling for tabs within their theme, which solves this issue on their side: pydata/pydata-sphinx-theme#1555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant