skipping artifact paths #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 13, 2020
choldgraf
commented
Jun 12, 2020
|
Thanks @AakashGfude for pushing updates to the PR! I think that this is now ready to go w/ tests and such. @chrisjsewell when you have a minute could you give a quick look to make sure it looks OK? |
|
I'm going to close this because it's no longer up to date, and I'm assuming this issue isn't a huge priority since it hasn't raised any major problems w/o being merged. Someone else is welcome to pick it up but I don't have time to see it through |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that this could address #43, though it doesn't yet have a test to confirm.
I just wanted to put this here in case others want to run with it and fix the bug properly. Please feel free to finish up this PR in my branch or in your own PR!
I think it:
closes executablebooks/MyST-NB#122
closes #43