Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions for using on RTD #155

Open
choldgraf opened this issue Jun 2, 2020 · 4 comments · May be fixed by #156
Open

Instructions for using on RTD #155

choldgraf opened this issue Jun 2, 2020 · 4 comments · May be fixed by #156
Labels
documentation Improvements or additions to documentation

Comments

@choldgraf
Copy link
Member

A few folks now have run into gotchas or had confusion about how to use MyST on readthedocs. We should add short instructions for how to configure a repository to do so. I think probably this just means including instructions on how to install the right packages on RTD.

@choldgraf choldgraf added the documentation Improvements or additions to documentation label Jun 2, 2020
@chrisjsewell
Copy link
Member

I think probably just make sphinx a core requirement, rather than an extra requirement will fix this. I originally wanted to keep sphinx an extra when this package contained aspects of the markdown parsing, which is not really the case any more, so I doubt there is really any use for it which doesn't include sphinx

@mlncn
Copy link

mlncn commented Jun 3, 2020

With nothing but myst_parser[sphinx] in requirements.txt i tried this morning and got this build error:

DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained. pip 21.0 will drop support for Python 2.7 in January 2021. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support
ERROR: Could not find a version that satisfies the requirement myst_parser[sphinx] (from -r requirements.txt (line 1)) (from versions: none)
ERROR: No matching distribution found for myst_parser[sphinx] (from -r requirements.txt (line 1))

And essentially the same error when i initially tried with a dash not an underscore, or without the [sphinx] part, whether myst-parser or myst_parser.

Should i try to include the git repository directly with git+https://github.com/executablebooks/MyST-Parser.git?

@chrisjsewell
Copy link
Member

chrisjsewell commented Jun 3, 2020

@mlncn it sounds like you have not created a readthedocs.yml for your repository, to configure how readthedocs build your documentation: https://docs.readthedocs.io/en/latest/config-file/v2.html, e.g.:

version: 2
python:
  version: 3
  install:
      - method: pip
        path: .

@mlncn mlncn linked a pull request Jun 3, 2020 that will close this issue
@mlncn
Copy link

mlncn commented Jun 3, 2020

@chrisjsewell ah! Thank you. Apologies, this project was set up in 2018 (cloned from an even earlier one) and i'm switching to MyST after your helpful note in ReCommonMark's queue. The conversion worked!

So i can vouch for the contents of my pull request, with the exception of the conf.py file— pretty sure at least an empty def setup(app): line will be needed at the bottom but i was trying to go minimal. Maybe the instructions just have to say to use sphinx-quickstart and modify. Will try to test later if no one else gets to it.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants