Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce package size: #4

Open
2 tasks done
gingerchew opened this issue Jun 25, 2020 · 3 comments · Fixed by #15, #19 or #20
Open
2 tasks done

Reduce package size: #4

gingerchew opened this issue Jun 25, 2020 · 3 comments · Fixed by #15, #19 or #20
Labels
enhancement New feature or request
Milestone

Comments

@gingerchew
Copy link
Member

gingerchew commented Jun 25, 2020

Without having looked into it in depth

Convert sha256 function into SubtleCrypto

  • Convert sha256 function to use SHA256 Library
  • Add "mangle" property to package.json

There may be other opportunities, but using microbundle does a lot of the work for us

@gingerchew
Copy link
Member Author

SubtleCrypto isn't going to be a solution here since it is promise based.

Looping indefinitely and promises are not exactly pb & j. Instead I think it's best to switch to a small sha256 library and use that instead.

I've been working on this on the side. I think it may be in vain, but I'd like to do some more research and see if it is possible to make it smaller and not lose the speed it already has

@gingerchew
Copy link
Member Author

Didn't end up converting to the other hashing library, I found a codepen sha256 to convert to. This brought the package size down significantly. It's now smaller than the original hashing library.

@gingerchew gingerchew linked a pull request Jul 5, 2020 that will close this issue
@gingerchew
Copy link
Member Author

I think this needs to be kept on hold until all other tasks are done in the To-Do list to make sure new features aren't increasing the package size afterwards

@gingerchew gingerchew added the enhancement New feature or request label Jul 5, 2020
This was linked to pull requests Jul 7, 2020
@gingerchew gingerchew added 2.0 Next Major Release and removed 2.0 Next Major Release labels Aug 21, 2020
@gingerchew gingerchew added this to the 2.0 milestone Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant