From 1ed0fe035a0776000b45924d03f27fbb399cf6be Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Arno=C5=A1t=20Pleskot?= Date: Thu, 13 Jul 2023 14:09:30 +0200 Subject: [PATCH 1/2] fix: for..of in disconnecting event --- src/index.ts | 6 ++++-- tsconfig.json | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/index.ts b/src/index.ts index 65cc345..8b8b16b 100755 --- a/src/index.ts +++ b/src/index.ts @@ -80,9 +80,11 @@ try { socket.on("disconnecting", async () => { socketDebug(`${socket.id} has disconnected`); - for (const roomID in socket.rooms) { + for (const roomID of socket.rooms) { const otherClients = (await io.in(roomID).fetchSockets()).filter( - (_socket) => _socket.id !== socket.id, + (_socket) => { + return _socket.id !== socket.id; + }, ); if (otherClients.length > 0) { diff --git a/tsconfig.json b/tsconfig.json index a239fb1..c4007dc 100755 --- a/tsconfig.json +++ b/tsconfig.json @@ -1,6 +1,6 @@ { "compilerOptions": { - "target": "es5", + "target": "es2020", "lib": ["dom", "dom.iterable", "esnext"], "allowJs": true, "skipLibCheck": true, From d8173c082474e5a891fd01ee5a36686f7c560fa2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Arno=C5=A1t=20Pleskot?= Date: Thu, 13 Jul 2023 14:43:16 +0200 Subject: [PATCH 2/2] chore: remove braces from filter function --- src/index.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/index.ts b/src/index.ts index 8b8b16b..c6d4720 100755 --- a/src/index.ts +++ b/src/index.ts @@ -82,9 +82,7 @@ try { socketDebug(`${socket.id} has disconnected`); for (const roomID of socket.rooms) { const otherClients = (await io.in(roomID).fetchSockets()).filter( - (_socket) => { - return _socket.id !== socket.id; - }, + (_socket) => _socket.id !== socket.id, ); if (otherClients.length > 0) {