Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme color detection #130

Open
Noobsai opened this issue Oct 8, 2020 · 2 comments
Open

Theme color detection #130

Noobsai opened this issue Oct 8, 2020 · 2 comments

Comments

@Noobsai
Copy link

Noobsai commented Oct 8, 2020

Why is removed detection of background color from user theme in commit ed740bd? In the last version panel is black if custom color is not specified.

@ewlsh
Copy link
Owner

ewlsh commented Oct 8, 2020

Three Reasons:

  • The theme detection code made the extension more complex and harder to maintain
  • A lot of themes are too opinionated for this extension to work
  • I've had issues with accessing theme information during unlocking, locking, or suspend led to repeated and unpredictable crashes.

If you would like to theme the shell you can also set a color that matches for now. Alternatively, it is now fairly easy for a theme to add panel transparency.

Long-term I plan to support wallpaper color detection.

@ewlsh
Copy link
Owner

ewlsh commented Oct 8, 2020

#116 lays out my future plans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants