Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider re-openning this repo #1131

Open
cargallo opened this issue Jan 8, 2020 · 12 comments
Open

Consider re-openning this repo #1131

cargallo opened this issue Jan 8, 2020 · 12 comments

Comments

@cargallo
Copy link

cargallo commented Jan 8, 2020

react-native-firebase is no longer developing a solution for notification in V6 version. So, please reconsider the repo deprecation

@phatlaunchdeck
Copy link

I would +1 this so bad, I'm still using this repo in my 10+ on-going projects right now

@Desintegrator
Copy link

Desintegrator commented Jan 22, 2020

+1

2 similar comments
@danielvportlandia
Copy link

+1

@vomchik
Copy link

vomchik commented Feb 19, 2020

+1

@temitope
Copy link

Here is a link explaining the drop in support for notifications that came from the RNF v6 jump.

invertase/react-native-firebase#2566 (comment)

This repo is quite relevant and valuable to the community. Not sure if @evollu is interested in resurecting for open source input.

@phatlaunchdeck
Copy link

@evollu You have any thinking over this yet?

@vomchik
Copy link

vomchik commented Apr 19, 2020

FYI: in react-native-firebae v6.4.0 was add two methods for notifacion, getInitialNotification and onNotofocationOpened. I think it will be enough for most apps.

@phatlaunchdeck
Copy link

@vomchik I haven't used react-native-firebase for a while now, but by the sound of those methods, I would assume that onNotificationOpened only get triggered when the user taps onto the notification, and that is not enough since on all of my projects, the data needs processing as soon as notification comes in, not when the user taps on it.

@vomchik
Copy link

vomchik commented Apr 19, 2020

I see, but if you want to catch a incoming notification in the foreground please use onMessage handler.

@phatlaunchdeck
Copy link

Well that would do for the foreground case, but what if when the app is running but in the background? Any method for that or would the onMessage() handle that case too?

@vomchik
Copy link

vomchik commented Apr 19, 2020

As far I remember it also will be handled by onMessage, please check a documentation 🕵️‍♂️

@phatlaunchdeck
Copy link

Ah if so that would be nice, I'll check it out, thanks!

However, I still would like @evollu to re-open this repo regardless. I've been forking this repo to fix AndroidX support along with some other bug fixes but if he's not coming back I might have to dig up my rusty Java skill from college again to add support for new features of FCM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants