Safe Web Core
+# 
-[](https://github.com/safe-global/web-core/blob/main/LICENSE)
-
-
-[](https://www.gitpoap.io/gh/safe-global/web-core)
+[](https://github.com/safe-global/safe-wallet-web/blob/main/LICENSE)
+
+
+[](https://www.gitpoap.io/gh/safe-global/safe-wallet-web)
The default Safe web interface.
@@ -19,24 +19,29 @@ Create a `.env` file with environment variables. You can use the `.env.example`
Here's the list of all the required and optional variables:
-| Env variable | | Description |
-| ------------ | -------- | ----------- |
-| `NEXT_PUBLIC_IS_PRODUCTION` | optional | Set to `true` to build a minified production app |
-| `NEXT_PUBLIC_GATEWAY_URL_PRODUCTION` | optional | The base URL for the [Safe Client Gateway](https://github.com/safe-global/safe-client-gateway) |
-| `NEXT_PUBLIC_GATEWAY_URL_STAGING` | optional | The base CGW URL on staging |
-| `NEXT_PUBLIC_SAFE_VERSION` | optional | The latest version of the Safe contract, defaults to 1.3.0 |
-| `NEXT_PUBLIC_INFURA_TOKEN` | **required** | [Infura](https://docs.infura.io/infura/networks/ethereum/how-to/secure-a-project/project-id) RPC API token |
-| `NEXT_PUBLIC_SAFE_APPS_INFURA_TOKEN` | optional | Infura token for Safe Apps, falls back to `NEXT_PUBLIC_INFURA_TOKEN` |
-| `NEXT_PUBLIC_WC_BRIDGE` | optional | [WalletConnect](https://docs.walletconnect.com/1.0/bridge-server) bridge URL, falls back to the public WC bridge |
-| `NEXT_PUBLIC_TENDERLY_ORG_NAME` | optional | [Tenderly](https://tenderly.co) org name for Transaction Simulation |
-| `NEXT_PUBLIC_TENDERLY_PROJECT_NAME` | optional | Tenderly project name |
-| `NEXT_PUBLIC_TENDERLY_SIMULATE_ENDPOINT_URL` | optional | Tenderly simulation URL |
-| `NEXT_PUBLIC_BEAMER_ID` | optional | [Beamer](https://www.getbeamer.com) is a news feed for in-app announcements |
-| `NEXT_PUBLIC_GOOGLE_TAG_MANAGER_ID` | optional | [GTM](https://tagmanager.google.com) project id |
-| `NEXT_PUBLIC_GOOGLE_TAG_MANAGER_DEVELOPMENT_AUTH` | optional | Dev GTM key |
-| `NEXT_PUBLIC_GOOGLE_TAG_MANAGER_LATEST_AUTH` | optional | Preview GTM key |
-| `NEXT_PUBLIC_GOOGLE_TAG_MANAGER_LIVE_AUTH` | optional | Production GTM key |
-| `NEXT_PUBLIC_SENTRY_DSN` | optional | [Sentry](https://sentry.io) id for tracking runtime errors |
+| Env variable | | Description
+| ------------------------------------------------------ | ------------ | -----------
+| `NEXT_PUBLIC_INFURA_TOKEN` | **required** | [Infura](https://docs.infura.io/infura/networks/ethereum/how-to/secure-a-project/project-id) RPC API token
+| `NEXT_PUBLIC_SAFE_APPS_INFURA_TOKEN` | optional | Infura token for Safe Apps, falls back to `NEXT_PUBLIC_INFURA_TOKEN`
+| `NEXT_PUBLIC_IS_PRODUCTION` | optional | Set to `true` to build a minified production app
+| `NEXT_PUBLIC_GATEWAY_URL_PRODUCTION` | optional | The base URL for the [Safe Client Gateway](https://github.com/safe-global/safe-client-gateway)
+| `NEXT_PUBLIC_GATEWAY_URL_STAGING` | optional | The base CGW URL on staging
+| `NEXT_PUBLIC_SAFE_VERSION` | optional | The latest version of the Safe contract, defaults to 1.3.0
+| `NEXT_PUBLIC_WC_BRIDGE` | optional | [WalletConnect v1](https://docs.walletconnect.com/1.0/bridge-server) bridge URL, falls back to the public WC bridge
+| `NEXT_PUBLIC_WC_PROJECT_ID` | optional | [WalletConnect v2](https://docs.walletconnect.com/2.0/cloud/relay) project ID
+| `NEXT_PUBLIC_TENDERLY_ORG_NAME` | optional | [Tenderly](https://tenderly.co) org name for Transaction Simulation
+| `NEXT_PUBLIC_TENDERLY_PROJECT_NAME` | optional | Tenderly project name
+| `NEXT_PUBLIC_TENDERLY_SIMULATE_ENDPOINT_URL` | optional | Tenderly simulation URL
+| `NEXT_PUBLIC_BEAMER_ID` | optional | [Beamer](https://www.getbeamer.com) is a news feed for in-app announcements
+| `NEXT_PUBLIC_GOOGLE_TAG_MANAGER_ID` | optional | [GTM](https://tagmanager.google.com) project id
+| `NEXT_PUBLIC_GOOGLE_TAG_MANAGER_DEVELOPMENT_AUTH` | optional | Dev GTM key
+| `NEXT_PUBLIC_GOOGLE_TAG_MANAGER_LATEST_AUTH` | optional | Preview GTM key
+| `NEXT_PUBLIC_GOOGLE_TAG_MANAGER_LIVE_AUTH` | optional | Production GTM key
+| `NEXT_PUBLIC_SENTRY_DSN` | optional | [Sentry](https://sentry.io) id for tracking runtime errors
+| `NEXT_PUBLIC_SAFE_GELATO_RELAY_SERVICE_URL_PRODUCTION` | optional | [Safe Gelato Relay Service](https://github.com/safe-global/safe-gelato-relay-service) URL to allow relaying transactions via Gelato
+| `NEXT_PUBLIC_SAFE_GELATO_RELAY_SERVICE_URL_STAGING` | optional | Relay URL on staging
+| `NEXT_PUBLIC_IS_OFFICIAL_HOST` | optional | Whether it's the official distribution of the app, or a fork; has legal implications. Set to true only if you also update the legal pages like Imprint and Terms of use
+| `NEXT_PUBLIC_REDEFINE_API` | optional | Redefine API base URL
If you don't provide some of the optional vars, the corresponding features will be disabled in the UI.
@@ -59,11 +64,13 @@ Open [http://localhost:3000](http://localhost:3000) with your browser to see the
## Lint
ESLint:
+
```
yarn lint --fix
```
Prettier:
+
```
yarn prettier
```
@@ -71,22 +78,27 @@ yarn prettier
## Tests
Unit tests:
+
```
yarn test --watch
```
### Cypress tests
+
Build and generarate a static site:
+
```
yarn build && yarn export
```
Serve the static files:
+
```
yarn serve
```
Launch the Cypress UI:
+
```
yarn cypress:open
```
@@ -94,17 +106,22 @@ yarn cypress:open
You can then choose which e2e tests to run.
## Component template
+
To create a new component from a template:
+
```
yarn cmp MyNewComponent
```
## Frameworks
- * [Safe Core SDK](https://github.com/safe-global/safe-core-sdk)
- * [Safe Gateway SDK](https://github.com/safe-global/safe-gateway-typescript-sdk)
- * Next.js
- * React
- * Redux
- * MUI
- * ethers.js
- * web3-onboard
+
+This app is built using the following frameworks:
+
+- [Safe Core SDK](https://github.com/safe-global/safe-core-sdk)
+- [Safe Gateway SDK](https://github.com/safe-global/safe-gateway-typescript-sdk)
+- Next.js
+- React
+- Redux
+- MUI
+- ethers.js
+- web3-onboard
diff --git a/cypress.config.js b/cypress.config.js
index 99f64873..16a50834 100644
--- a/cypress.config.js
+++ b/cypress.config.js
@@ -5,7 +5,7 @@ export default defineConfig({
trashAssetsBeforeRuns: true,
retries: {
- runMode: 2,
+ runMode: 3,
openMode: 0,
},
diff --git a/cypress/e2e/safe-apps/apps_list.cy.js b/cypress/e2e/safe-apps/apps_list.cy.js
index 77eb75b3..87ae81ff 100644
--- a/cypress/e2e/safe-apps/apps_list.cy.js
+++ b/cypress/e2e/safe-apps/apps_list.cy.js
@@ -22,7 +22,7 @@ describe('The Safe Apps list', () => {
it('should show a not found text when no match', () => {
cy.findByRole('textbox').clear().type('atextwithoutresults')
- cy.findByText(/no apps found/i).should('exist')
+ cy.findByText(/no Safe Apps found/i).should('exist')
})
})
@@ -31,7 +31,7 @@ describe('The Safe Apps list', () => {
cy.findByRole('textbox').clear()
cy.findByLabelText(/pin walletconnect/i).click()
cy.findByLabelText(/pin transaction builder/i).click()
- cy.findByText(/bookmarked apps/i).click()
+ cy.findByText(/bookmarked Apps/i).click()
cy.findByText('ALL (2)').should('exist')
})
@@ -51,9 +51,9 @@ describe('The Safe Apps list', () => {
cy.intercept('GET', 'https://my-invalid-custom-app.com/manifest.json', {
name: 'My Custom App',
})
- cy.findByText(/my custom apps/i).click()
- cy.findByText(/add custom app/i).click({ force: true })
- cy.findByLabelText(/app url/i)
+ cy.findByText(/my custom Apps/i).click()
+ cy.findByText(/add custom Safe App/i).click({ force: true })
+ cy.findByLabelText(/Safe App url/i)
.clear()
.type('https://my-invalid-custom-app.com')
cy.contains("The app doesn't support Safe App functionality").should('exist')
@@ -66,7 +66,7 @@ describe('The Safe Apps list', () => {
icons: [{ src: 'logo.svg', sizes: 'any', type: 'image/svg+xml' }],
})
- cy.findByLabelText(/app url/i)
+ cy.findByLabelText(/Safe App url/i)
.clear()
.type('https://my-valid-custom-app.com')
cy.findByRole('heading', { name: /my custom app/i }).should('exist')
diff --git a/cypress/e2e/safe-apps/info_modal.cy.js b/cypress/e2e/safe-apps/info_modal.cy.js
index 3403d854..5f6ea1e1 100644
--- a/cypress/e2e/safe-apps/info_modal.cy.js
+++ b/cypress/e2e/safe-apps/info_modal.cy.js
@@ -9,7 +9,7 @@ describe('The Safe Apps info modal', () => {
describe('when opening a Safe App', () => {
it('should show the disclaimer', () => {
cy.findByRole('link', { name: /logo.*walletconnect/i }).click()
- cy.findByRole('link', { name: /open app/i }).click()
+ cy.findByRole('link', { name: /open Safe App/i }).click()
cy.findByRole('heading', { name: /disclaimer/i }).should('exist')
})
diff --git a/cypress/e2e/safe-apps/permissions_settings.cy.js b/cypress/e2e/safe-apps/permissions_settings.cy.js
index 1d2b0bc4..7093480e 100644
--- a/cypress/e2e/safe-apps/permissions_settings.cy.js
+++ b/cypress/e2e/safe-apps/permissions_settings.cy.js
@@ -42,6 +42,7 @@ describe('The Safe Apps permissions settings section', () => {
})
cy.visit(`${TEST_SAFE}/settings/safe-apps`, { failOnStatusCode: false })
+ cy.findByText(/accept selection/i).click()
})
it('should show the permissions configuration for each stored app', () => {
diff --git a/cypress/e2e/smoke/address_book.cy.js b/cypress/e2e/smoke/address_book.cy.js
index 6a51e810..442c8983 100644
--- a/cypress/e2e/smoke/address_book.cy.js
+++ b/cypress/e2e/smoke/address_book.cy.js
@@ -19,7 +19,7 @@ const GNO_CSV_ENTRY = {
describe('Address book', () => {
before(() => {
- cy.visit(`/${GOERLI_TEST_SAFE}/address-book`, { failOnStatusCode: false })
+ cy.visit(`/address-book?safe=${GOERLI_TEST_SAFE}`)
cy.contains('Accept selection').click()
// Waits for the Address Book table to be in the page
cy.contains('p', 'Address book').should('be.visible')
@@ -84,7 +84,7 @@ describe('Address book', () => {
cy.contains('Gnosis Chain').click()
// Navigate to the Address Book page
- cy.visit(`/${GNO_TEST_SAFE}/address-book`, { failOnStatusCode: false })
+ cy.visit(`/address-book?safe=${GNO_TEST_SAFE}`)
// Waits for the Address Book table to be in the page
cy.contains('p', 'Address book').should('be.visible')
diff --git a/cypress/e2e/smoke/balances.cy.js b/cypress/e2e/smoke/balances.cy.js
index 617d8a35..3702e556 100644
--- a/cypress/e2e/smoke/balances.cy.js
+++ b/cypress/e2e/smoke/balances.cy.js
@@ -2,9 +2,8 @@ const assetsTable = '[aria-labelledby="tableTitle"] > tbody'
const balanceSingleRow = '[aria-labelledby="tableTitle"] > tbody tr'
const TEST_SAFE = 'gor:0x97d314157727D517A706B5D08507A1f9B44AaaE9'
-// TODO: replace PAGINATION_TEST_SAFE for a Görli safe with > 25 tokens
-const PAGINATION_TEST_SAFE = 'rin:0x656c1121a6f40d25C5CFfF0Db08938DB7633B2A3'
-const ASSETS_LENGTH = 7
+const PAGINATION_TEST_SAFE = 'gor:0x850493a15914aAC05a821A3FAb973b4598889A7b'
+const ASSETS_LENGTH = 8
const ASSET_NAME_COLUMN = 0
const TOKEN_AMOUNT_COLUMN = 1
const FIAT_AMOUNT_COLUMN = 2
@@ -14,28 +13,24 @@ describe('Assets > Coins', () => {
const fiatRegex = new RegExp(`([0-9]{1,3},)*[0-9]{1,3}.[0-9]{2}`)
before(() => {
+ cy.disableProdCGW()
+
// Open the Safe used for testing
- cy.visit(`/${TEST_SAFE}/balances`, { failOnStatusCode: false })
+ cy.visit(`/balances?safe=${TEST_SAFE}`)
cy.contains('button', 'Accept selection').click()
// Table is loaded
cy.contains('Görli Ether')
cy.contains('button', 'Got it').click()
+
+ cy.get(balanceSingleRow).should('have.length.lessThan', ASSETS_LENGTH)
+ cy.contains('div', 'Default tokens').click()
+ cy.wait(100)
+ cy.contains('div', 'All tokens').click()
+ cy.get(balanceSingleRow).should('have.length', ASSETS_LENGTH)
})
describe('should have different tokens', () => {
- it(`should have ${ASSETS_LENGTH} entries in the table`, () => {
- // "Spam" tokens filtered
- cy.get(balanceSingleRow).should('have.length', 3)
-
- // Enable all tokens
- cy.contains('div', 'Default tokens').click()
- cy.wait(100)
- cy.contains('div', 'All tokens').click()
-
- cy.get(balanceSingleRow).should('have.length', ASSETS_LENGTH)
- })
-
it('should have Dai', () => {
// Row should have an image with alt text "Dai"
cy.contains('Dai')
@@ -175,18 +170,48 @@ describe('Assets > Coins', () => {
})
})
- describe.skip('pagination should work', () => {
+ describe('tokens can be manually hidden', () => {
+ it('hide single token', () => {
+ // Click hide Dai
+ cy.contains('Dai').parents('tr').find('button[aria-label="Hide asset"]').click()
+ // time to hide the asset
+ cy.wait(350)
+ cy.contains('Dai').should('not.exist')
+ })
+
+ it('unhide hidden token', () => {
+ // Open hide token menu
+ cy.contains('1 hidden token').click()
+ // uncheck dai token
+ cy.contains('Dai').parents('tr').find('input[type="checkbox"]').click()
+ // apply changes
+ cy.contains('Save').click()
+ // Dai token is visible again
+ cy.contains('Dai')
+ // The menu button shows "Hide tokens" label again
+ cy.contains('Hide tokens')
+ })
+ })
+
+ describe('pagination should work', () => {
before(() => {
// Open the Safe used for testing pagination
- cy.visit(`/${PAGINATION_TEST_SAFE}/balances`, { failOnStatusCode: false })
+ cy.visit(`/balances?safe=${PAGINATION_TEST_SAFE}`)
+ cy.contains('button', 'Accept selection').click()
+
// Table is loaded
cy.contains('Görli Ether')
+ cy.contains('button', 'Got it').click()
+ // Enable all tokens
+ cy.contains('div', 'Default tokens').click()
+ cy.wait(100)
+ cy.contains('div', 'All tokens').click()
})
it('should allow changing rows per page and navigate to next and previous page', () => {
// Table should have 25 rows inittially
cy.contains('Rows per page:').next().contains('25')
- cy.contains('1–25 of 27')
+ cy.contains('1–25 of')
cy.get(balanceSingleRow).should('have.length', 25)
// Change to 10 rows per page
@@ -196,22 +221,22 @@ describe('Assets > Coins', () => {
// Table should have 10 rows
cy.contains('Rows per page:').next().contains('10')
- cy.contains('1–10 of 27')
+ cy.contains('1–10 of')
cy.get(balanceSingleRow).should('have.length', 10)
// Click on the next page button
cy.get('button[aria-label="Go to next page"]').click({ force: true })
cy.get('button[aria-label="Go to next page"]').click({ force: true })
- // Table should have 7 rows
- cy.contains('21–27 of 27')
- cy.get(balanceSingleRow).should('have.length', 7)
+ // Table should have N rows
+ cy.contains('21–28 of')
+ cy.get(balanceSingleRow).should('have.length', ASSETS_LENGTH)
// Click on the previous page button
cy.get('button[aria-label="Go to previous page"]').click({ force: true })
// Table should have 10 rows
- cy.contains('11–20 of 27')
+ cy.contains('11–20 of')
cy.get(balanceSingleRow).should('have.length', 10)
})
})
diff --git a/cypress/e2e/smoke/beamer.cy.js b/cypress/e2e/smoke/beamer.cy.js
index 5f723c81..6267ba94 100644
--- a/cypress/e2e/smoke/beamer.cy.js
+++ b/cypress/e2e/smoke/beamer.cy.js
@@ -3,30 +3,29 @@ const TEST_SAFE = 'gor:0x97d314157727D517A706B5D08507A1f9B44AaaE9'
describe('Beamer', () => {
it('should require accept "Updates" cookies to display Beamer', () => {
// Disable PWA, otherwise it will throw a security error
- cy.visit(`/${TEST_SAFE}/address-book`, { failOnStatusCode: false })
+ cy.visit(`/address-book?safe=${TEST_SAFE}`)
// Way to select the cookies banner without an id
- cy.contains('We use cookies to provide')
cy.contains('Accept selection').click()
- cy.contains('We use cookies to provide').should('not.exist')
// Open What's new
cy.contains("What's new").click()
- // Tells that the user has to accept "Updates & Feedback" cookies
- cy.contains('We use cookies to provide').parent('div').contains('accept the "Updates & Feedback"')
+ // Tells that the user has to accept "Beamer" cookies
+ cy.contains('accept the "Beamer" cookies')
- // "Updates" is checked when the banner opens
- cy.contains('We use cookies to provide').parent('div').get('input[name="updates"]').should('be.checked')
+ // "Beamer" is checked when the banner opens
+ cy.get('input[id="beamer"]').should('be.checked')
// Accept "Updates & Feedback" cookies
cy.contains('Accept selection').click()
- cy.contains('We use cookies to provide').should('not.exist')
+ cy.contains('Accept selection').should('not.exist')
// wait for Beamer cookies to be set
- cy.wait(3000)
+ cy.wait(600)
// Open What's new
cy.contains("What's new").click({ force: true }) // clicks through the "lastPostTitle"
+
cy.get('#beamerOverlay .iframeCointaner').should('exist')
})
})
diff --git a/cypress/e2e/smoke/create_safe_simple.cy.js b/cypress/e2e/smoke/create_safe_simple.cy.js
index b03f4877..36f34979 100644
--- a/cypress/e2e/smoke/create_safe_simple.cy.js
+++ b/cypress/e2e/smoke/create_safe_simple.cy.js
@@ -8,12 +8,12 @@ describe('Create Safe form', () => {
cy.visit('/welcome')
// Close cookie banner
- cy.contains('button', 'Accept all').click()
+ cy.contains('button', 'Accept selection').click()
// Ensure wallet is connected to correct chain via header
cy.contains('E2E Wallet @ Görli')
- cy.contains('Create new Safe').click()
+ cy.contains('Create new Account').click()
})
it('should allow setting a name', () => {
@@ -31,10 +31,6 @@ describe('Create Safe form', () => {
cy.get('[data-cy="create-safe-select-network"]').click()
cy.contains('Ethereum').click()
- // Network hint should be displayed
- cy.contains('Change your wallet network').should('be.visible')
- cy.contains('button', 'Next').should('be.disabled')
-
// Switch back to Görli
cy.get('[data-cy="create-safe-select-network"]').click()
cy.contains('li span', 'Görli').click()
diff --git a/cypress/e2e/create_tx.cy.js b/cypress/e2e/smoke/create_tx.cy.js
similarity index 65%
rename from cypress/e2e/create_tx.cy.js
rename to cypress/e2e/smoke/create_tx.cy.js
index f03012da..ee09b6b4 100644
--- a/cypress/e2e/create_tx.cy.js
+++ b/cypress/e2e/smoke/create_tx.cy.js
@@ -2,15 +2,16 @@ const SAFE = 'gor:0x04f8b1EA3cBB315b87ced0E32deb5a43cC151a91'
const EOA = '0xE297437d6b53890cbf004e401F3acc67c8b39665'
// generate number between 0.00001 and 0.00020
-const sendValue = Math.floor(Math.random() * 20 + 1) / 100000
let recommendedNonce
+const sendValue = Math.floor(Math.random() * 20 + 1) / 100000
const currentNonce = 3
describe('Queue a transaction on 1/N', () => {
before(() => {
cy.connectE2EWallet()
+ cy.useProdCGW()
- cy.visit(`/${SAFE}/home`, { failOnStatusCode: false })
+ cy.visit(`/home?safe=${SAFE}`)
cy.contains('Accept selection').click()
})
@@ -19,7 +20,9 @@ describe('Queue a transaction on 1/N', () => {
// Assert that "New transaction" button is visible
cy.contains('New transaction', {
timeout: 60_000, // `lastWallet` takes a while initialize in CI
- }).should('be.visible')
+ })
+ .should('be.visible')
+ .and('not.be.disabled')
// Open the new transaction modal
cy.contains('New transaction').click()
@@ -32,11 +35,32 @@ describe('Queue a transaction on 1/N', () => {
cy.get('input[name="recipient"]').type(EOA)
// Click on the Token selector
cy.get('input[name="tokenAddress"]').prev().click()
- cy.get('ul[role="listbox"]').contains('Görli Ether').click()
+ cy.get('ul[role="listbox"]')
+ .contains(/G(ö|oe)rli Ether/)
+ .click()
// Insert max amount
cy.contains('Max').click()
+ // Validates the "Max" button action, then clears and sets the actual sendValue
+ cy.get('input[name="tokenAddress"]')
+ .prev()
+ .find('p')
+ .contains(/G(ö|oe)rli Ether/)
+ .next()
+ .then((element) => {
+ const maxBalance = element.text().replace(' GOR', '').trim()
+ cy.wrap(element)
+ .parents('form')
+ .find('label')
+ .contains('Amount')
+ .next()
+ .find('input')
+ .should('have.value', maxBalance)
+ .clear()
+ .type(sendValue)
+ })
+
cy.contains('Next').click()
})
@@ -61,7 +85,7 @@ describe('Queue a transaction on 1/N', () => {
// Changes nonce to next one
cy.contains('Signing the transaction with nonce').click()
cy.contains('button', 'Edit').click()
- cy.get('label').contains('Safe transaction nonce').next().clear().type(currentNonce)
+ cy.get('label').contains('Safe Account transaction nonce').next().clear().type(currentNonce)
cy.contains('Confirm').click()
// Asserts the execute checkbox exists
@@ -77,6 +101,32 @@ describe('Queue a transaction on 1/N', () => {
})
cy.contains('Estimated fee').should('exist')
+ // Asserting the sponsored info is present
+ cy.contains('Sponsored by').should('be.visible')
+
+ cy.get('span').contains('Estimated fee').next().should('have.css', 'text-decoration-line', 'line-through')
+ cy.contains('Transactions per hour')
+ cy.contains('5 of 5')
+
+ cy.contains('Estimated fee').click()
+ cy.contains('Edit').click()
+ cy.contains('Owner transaction (Execution)').parents('form').as('Paramsform')
+
+ // Only gaslimit should be editable when the relayer is selected
+ const arrayNames = ['Wallet nonce', 'Max priority fee (Gwei)', 'Max fee (Gwei)']
+ arrayNames.forEach((element) => {
+ cy.get('@Paramsform').find('label').contains(`${element}`).next().find('input').should('be.disabled')
+ })
+
+ cy.get('@Paramsform')
+ .find('[name="gasLimit"]')
+ .clear()
+ .type('300000')
+ .invoke('prop', 'value')
+ .should('equal', '300000')
+ cy.get('@Paramsform').find('[name="gasLimit"]').parent('div').find('[data-testid="RotateLeftIcon"]').click()
+ cy.contains('Confirm').click()
+
// Asserts the execute checkbox is uncheckable
cy.contains('Execute transaction').click()
cy.get('@modal').within(() => {
@@ -89,6 +139,10 @@ describe('Queue a transaction on 1/N', () => {
expect(classListString).not.to.include('checked')
})
})
+
+ // If the checkbox is unchecked the relayer is not present
+ cy.get('@modal').should('not.contain', 'Sponsored by').and('not.contain', 'Transactions per hour')
+
cy.contains('Signing the transaction with nonce').should('exist')
// Changes back to recommended nonce
@@ -114,6 +168,8 @@ describe('Queue a transaction on 1/N', () => {
// Click on the notification
cy.contains('View transaction').click()
+ //cy.contains('Queue').click()
+
// Single Tx page
cy.contains('h3', 'Transaction details').should('be.visible')
diff --git a/cypress/e2e/smoke/dashboard.cy.js b/cypress/e2e/smoke/dashboard.cy.js
index 7c1a1888..8b62ed9e 100644
--- a/cypress/e2e/smoke/dashboard.cy.js
+++ b/cypress/e2e/smoke/dashboard.cy.js
@@ -2,8 +2,11 @@ const SAFE = encodeURIComponent('gor:0xCD4FddB8FfA90012DFE11eD4bf258861204FeEAE'
describe('Dashboard', () => {
before(() => {
+ cy.useProdCGW()
+
// Go to the test Safe home page
- cy.visit(`/home?safe=${SAFE}`, { failOnStatusCode: false })
+ cy.visit(`/home?safe=${SAFE}`)
+
cy.contains('button', 'Accept selection').click()
// Wait for dashboard to initialize
@@ -19,7 +22,8 @@ describe('Dashboard', () => {
cy.contains('0xCD4FddB8FfA90012DFE11eD4bf258861204FeEAE').should('exist')
cy.contains('2/3')
cy.get(`a[href="/balances?safe=${SAFE}"]`).contains('View assets')
- cy.contains('p', 'Tokens').next().contains('1')
+ // Text next to Tokens contains a number greater than 0
+ cy.contains('p', 'Tokens').next().contains('4')
cy.contains('p', 'NFTs').next().contains('0')
})
})
diff --git a/cypress/e2e/smoke/import_export_data.cy.js b/cypress/e2e/smoke/import_export_data.cy.js
new file mode 100644
index 00000000..f35de9f9
--- /dev/null
+++ b/cypress/e2e/smoke/import_export_data.cy.js
@@ -0,0 +1,71 @@
+import 'cypress-file-upload'
+const path = require('path')
+import { format } from 'date-fns'
+
+describe('Import Export Data', () => {
+ before(() => {
+ cy.visit(`/welcome`)
+ cy.contains('Accept selection').click()
+ // Waits for the Import button to be visible
+ cy.contains('button', 'Import').should('be.visible')
+ })
+
+ it('Uploads test file and access safe', () => {
+ cy.contains('button', 'Import').click()
+ //Uploads the file
+ cy.get('[type="file"]').attachFile('../fixtures/data_import.json')
+ //verifies that the modal says the amount of chains/addressbook values it uploaded
+ cy.contains('Added Safe Accounts on 3 chains').should('be.visible')
+ cy.contains('Address book for 3 chains').should('be.visible')
+ cy.contains('Settings').should('be.visible')
+ cy.contains('Bookmarked Safe Apps').should('be.visible')
+ cy.contains('Data import').parent().contains('button', 'Import').click()
+ //Click in one of the imported safes
+ cy.contains('safe 1 goerli').click()
+ })
+
+ it("Verify safe's address book imported data", () => {
+ //Verifies imported owners in the Address book
+ cy.contains('Address book').click()
+ cy.get('tbody tr:nth-child(1) td:nth-child(1)').contains('test1')
+ cy.get('tbody tr:nth-child(1) td:nth-child(2)').contains('0x61a0c717d18232711bC788F19C9Cd56a43cc8872')
+ cy.get('tbody tr:nth-child(2) td:nth-child(1)').contains('test2')
+ cy.get('tbody tr:nth-child(2) td:nth-child(2)').contains('0x7724b234c9099C205F03b458944942bcEBA13408')
+ })
+
+ it('Verify pinned apps', () => {
+ cy.get('aside').contains('li', 'Apps').click()
+ cy.contains('Bookmarked apps').click()
+ //Takes a some time to load the apps page, It waits for bookmark to be lighted up
+ cy.waitForSelector(() => {
+ return cy
+ .get('[aria-selected="true"] p')
+ .invoke('html')
+ .then((text) => text === 'Bookmarked apps')
+ })
+ cy.contains('Drain Account').should('be.visible')
+ cy.contains('Transaction Builder').should('be.visible')
+ })
+
+ it('Verify imported data in settings', () => {
+ //In the settings checks the checkboxes and darkmode enabled
+ cy.contains('Settings').click()
+ cy.contains('Appearance').click()
+ cy.contains('label', 'Prepend chain prefix to addresses').find('input[type="checkbox"]').should('not.be.checked')
+ cy.contains('label', 'Copy addresses with chain prefix').find('input[type="checkbox"]').should('not.be.checked')
+ cy.get('main').contains('label', 'Dark mode').find('input[type="checkbox"]').should('be.checked')
+ })
+
+ it('Verifies data for export in Data tab', () => {
+ cy.contains('div[role="tablist"] a', 'Data').click()
+ cy.contains('Added Safe Accounts on 3 chains').should('be.visible')
+ cy.contains('Address book for 3 chains').should('be.visible')
+ cy.contains('Bookmarked Safe Apps').should('be.visible')
+ const date = format(new Date(), 'yyyy-MM-dd', { timeZone: 'UTC' })
+ const fileName = `safe-${date}.json`
+ cy.contains('div', fileName).next().click()
+ const downloadsFolder = Cypress.config('downloadsFolder')
+ //File reading is failing in the CI. Can be tested locally
+ cy.readFile(path.join(downloadsFolder, fileName)).should('exist')
+ })
+})
diff --git a/cypress/e2e/smoke/load_safe.cy.js b/cypress/e2e/smoke/load_safe.cy.js
index d96be6ab..ee8bf21e 100644
--- a/cypress/e2e/smoke/load_safe.cy.js
+++ b/cypress/e2e/smoke/load_safe.cy.js
@@ -20,7 +20,7 @@ describe('Load existing Safe', () => {
cy.contains('Accept selection').click()
// Enters Loading Safe form
- cy.contains('button', 'Add existing Safe').click()
+ cy.contains('button', 'Add existing Account').click()
cy.contains('Connect wallet & select network')
})
diff --git a/cypress/e2e/smoke/nfts.cy.js b/cypress/e2e/smoke/nfts.cy.js
index 57df4458..deea8919 100644
--- a/cypress/e2e/smoke/nfts.cy.js
+++ b/cypress/e2e/smoke/nfts.cy.js
@@ -4,7 +4,7 @@ describe('Assets > NFTs', () => {
before(() => {
cy.connectE2EWallet()
- cy.visit(`/${TEST_SAFE}/balances/nfts`, { failOnStatusCode: false })
+ cy.visit(`/balances/nfts?safe=${TEST_SAFE}`)
cy.contains('button', 'Accept selection').click()
cy.contains('E2E Wallet @ Görli')
})
@@ -12,9 +12,6 @@ describe('Assets > NFTs', () => {
describe('should have NFTs', () => {
it('should have NFTs in the table', () => {
cy.get('tbody tr').should('have.length', 5)
- cy.contains('Please note that the links to OpenSea')
- cy.contains('button', 'Got it!').click()
- cy.contains('Please note that the links to OpenSea').should('not.exist')
})
it('should have info in the NFT row', () => {
@@ -80,9 +77,11 @@ describe('Assets > NFTs', () => {
cy.contains('button', 'Next').click()
// Review modal appears
- cy.contains('Review transaction')
+ cy.contains('Review NFT transaction')
cy.contains('Sending 2 NFTs from')
- cy.contains('Batched transactions')
+ cy.wait(1000)
+ cy.contains('Action 1')
+ cy.contains('Action 2')
cy.get('b:contains("safeTransferFrom")').should('have.length', 2)
cy.contains('button:not([disabled])', 'Submit')
})
diff --git a/cypress/e2e/smoke/pending_actions.cy.js b/cypress/e2e/smoke/pending_actions.cy.js
index 15a732ab..e381212f 100644
--- a/cypress/e2e/smoke/pending_actions.cy.js
+++ b/cypress/e2e/smoke/pending_actions.cy.js
@@ -3,14 +3,10 @@ const SAFE = 'gor:0xCD4FddB8FfA90012DFE11eD4bf258861204FeEAE'
describe('Pending actions', () => {
before(() => {
cy.connectE2EWallet()
+ cy.useProdCGW()
- cy.visit('/welcome')
-
- // Close cookie banner
- cy.contains('button', 'Accept all').click()
-
- // Ensure wallet is connected to correct chain via header
- cy.contains('E2E Wallet @ Görli')
+ cy.visit(`/welcome`)
+ cy.contains('button', 'Accept selection').click()
})
beforeEach(() => {
@@ -25,7 +21,7 @@ describe('Pending actions', () => {
it('should add the Safe with the pending actions', () => {
// Enters Loading Safe form
- cy.contains('button', 'Add existing Safe').click()
+ cy.contains('button', 'Add').click()
cy.contains('Connect wallet & select network')
// Inputs the Safe address
@@ -46,8 +42,8 @@ describe('Pending actions', () => {
cy.get('li').within(() => {
cy.contains('0xCD4F...eEAE').should('exist')
- cy.get('img[alt="E2E Wallet logo"]').next().contains('3').should('exist')
- cy.get('[data-testid=CheckIcon]').next().contains('3').should('exist')
+ cy.get('img[alt="E2E Wallet logo"]').next().contains('2').should('exist')
+ cy.get('[data-testid=CheckIcon]').next().contains('2').should('exist')
// click on the pending actions
cy.get('[data-testid=CheckIcon]').next().click()
@@ -59,12 +55,12 @@ describe('Pending actions', () => {
cy.contains('h3', 'Transactions').should('be.visible')
// contains 3 queued transactions
- cy.get('span:contains("1 out of 2")').should('have.length', 3)
+ cy.get('span:contains("1 out of 2")').should('have.length', 2)
// Ensure wallet is connected
- cy.contains('E2E Wallet @ Görli')
+ cy.contains('E2E Wallet @ Goerli')
// contains 3 signable transactions
- cy.get('span:contains("Needs your confirmation")').should('have.length', 3)
+ cy.get('span:contains("Needs your confirmation")').should('have.length', 2)
})
})
diff --git a/cypress/e2e/smoke/tx_history.cy.js b/cypress/e2e/smoke/tx_history.cy.js
index 2381e6dd..f5da4642 100644
--- a/cypress/e2e/smoke/tx_history.cy.js
+++ b/cypress/e2e/smoke/tx_history.cy.js
@@ -1,13 +1,15 @@
const SAFE = 'gor:0x97d314157727D517A706B5D08507A1f9B44AaaE9'
-const INCOMING = '/images/transactions/incoming.svg'
-const OUTGOING = '/images/transactions/outgoing.svg'
-const CONTRACT_INTERACTION = '/images/transactions/custom.svg'
+const INCOMING = 'Received'
+const OUTGOING = 'Sent'
+const CONTRACT_INTERACTION = 'Contract interaction'
describe('Transaction history', () => {
before(() => {
+ cy.useProdCGW()
+
// Go to the test Safe transaction history
- cy.visit(`/${SAFE}/transactions/history`, { failOnStatusCode: false })
+ cy.visit(`/transactions/history?safe=${SAFE}`)
cy.contains('button', 'Accept selection').click()
})
@@ -31,7 +33,7 @@ describe('Transaction history', () => {
.last()
.within(() => {
// Type
- cy.get('img').should('have.attr', 'src', INCOMING)
+ cy.get('iframe').should('have.attr', 'title', INCOMING)
cy.contains('div', 'Received').should('exist')
// Info
@@ -103,7 +105,7 @@ describe('Transaction history', () => {
.prev()
.within(() => {
// Type
- cy.get('img').should('have.attr', 'src', OUTGOING)
+ cy.get('iframe').should('have.attr', 'title', OUTGOING)
cy.contains('div', 'Sent').should('exist')
// Info
@@ -131,4 +133,28 @@ describe('Transaction history', () => {
cy.contains('span', 'Success').should('exist')
})
})
+
+ it('should expand/collapse all actions', () => {
+ // Open the tx details
+ cy.contains('div', 'Mar 24, 2023')
+ .next()
+ .click()
+ .within(() => {
+ cy.contains('True').should('not.be.visible')
+ cy.contains('1337').should('not.be.visible')
+ cy.contains('5688').should('not.be.visible')
+ cy.contains('Expand all').click()
+
+ // All the values in the actions must be visible
+ cy.contains('True').should('exist')
+ cy.contains('1337').should('exist')
+ cy.contains('5688').should('exist')
+
+ // After collapse all the same values should not be visible
+ cy.contains('Collapse all').click()
+ cy.contains('True').should('not.be.visible')
+ cy.contains('1337').should('not.be.visible')
+ cy.contains('5688').should('not.be.visible')
+ })
+ })
})
diff --git a/cypress/fixtures/data_import.json b/cypress/fixtures/data_import.json
new file mode 100644
index 00000000..b1e4a313
--- /dev/null
+++ b/cypress/fixtures/data_import.json
@@ -0,0 +1,158 @@
+{
+ "version": "2.0",
+ "data": {
+ "addressBook": {
+ "5": {
+ "0x61a0c717d18232711bC788F19C9Cd56a43cc8872": "test1",
+ "0x7724b234c9099C205F03b458944942bcEBA13408": "test2",
+ "0x6E45d69a383CECa3d54688e833Bd0e1388747e6B": "test3",
+ "0x10f999F150a2E7fd356Aa471bCBf0b75aA7b0e2A": "safe 1 goerli"
+ },
+ "100": {
+ "0x17b34aEf1428A358bA2eA360a098b8A3BEb698C8": "safe 1 GNO",
+ "0x11A6B41322C57Bd0e56cEe06abB11A1E5c1FF1BB": "Safe 2 GNO",
+ "0xB8d760a90a5ed54D3c2b3EFC231277e99188642A": "main xdai safe",
+ "0x11B1D54B66e5e226D6f89069c21A569A22D98cfd": "trez",
+ "0x61a0c717d18232711bC788F19C9Cd56a43cc8872": "test1",
+ "0x8aEf2f5c3F17261F6F1C4dA058D022BE92776af8": "ow1",
+ "0x0D65139Da4B36a8A39BF1b63e950038D42231b2e": "ow 2"
+ },
+ "137": {
+ "0xC680d44F526f4372693CAc21dcab255b77bc58F4": "Safe 1 Poly",
+ "0x61a0c717d18232711bC788F19C9Cd56a43cc8872": "Test1 Poly"
+ }
+ },
+ "addedSafes": {
+ "5": {
+ "0x10f999F150a2E7fd356Aa471bCBf0b75aA7b0e2A": {
+ "owners": [
+ {
+ "value": "0x8aEf2f5c3F17261F6F1C4dA058D022BE92776af8"
+ },
+ {
+ "value": "0x61a0c717d18232711bC788F19C9Cd56a43cc8872"
+ }
+ ],
+ "threshold": 2,
+ "ethBalance": "0"
+ }
+ },
+ "100": {
+ "0x17b34aEf1428A358bA2eA360a098b8A3BEb698C8": {
+ "owners": [
+ {
+ "value": "0x11B1D54B66e5e226D6f89069c21A569A22D98cfd"
+ }
+ ],
+ "threshold": 1,
+ "ethBalance": "0.001000002"
+ },
+ "0x11A6B41322C57Bd0e56cEe06abB11A1E5c1FF1BB": {
+ "owners": [
+ {
+ "value": "0x7724b234c9099C205F03b458944942bcEBA13408"
+ },
+ {
+ "value": "0x8aEf2f5c3F17261F6F1C4dA058D022BE92776af8"
+ },
+ {
+ "value": "0x0D65139Da4B36a8A39BF1b63e950038D42231b2e"
+ }
+ ],
+ "threshold": 1,
+ "ethBalance": "0"
+ },
+ "0xB8d760a90a5ed54D3c2b3EFC231277e99188642A": {
+ "owners": [
+ {
+ "value": "0x11B1D54B66e5e226D6f89069c21A569A22D98cfd"
+ },
+ {
+ "value": "0x457D3Fcb58401F9b98d83BC2fe7BF57FF57603AB"
+ },
+ {
+ "value": "0x61a0c717d18232711bC788F19C9Cd56a43cc8872"
+ },
+ {
+ "value": "0xFD71c1ABadBD37F60E4C8F208386dDFC4d2Bf01f"
+ },
+ {
+ "value": "0x5aC255889882aCd3da2aA939679E3f3d4cea221e"
+ },
+ {
+ "value": "0x474e5Ded6b5D078163BFB8F6dBa355C3aA5478C8"
+ },
+ {
+ "value": "0x86a9F6704280Ac2b99aBD60ed74bF9cF899bd925"
+ },
+ {
+ "value": "0x8aEf2f5c3F17261F6F1C4dA058D022BE92776af8"
+ },
+ {
+ "value": "0x0D65139Da4B36a8A39BF1b63e950038D42231b2e"
+ }
+ ],
+ "threshold": 1,
+ "ethBalance": "0.92132507668989"
+ }
+ },
+ "137": {
+ "0xC680d44F526f4372693CAc21dcab255b77bc58F4": {
+ "owners": [
+ {
+ "value": "0x0D65139Da4B36a8A39BF1b63e950038D42231b2e"
+ },
+ {
+ "value": "0x8aEf2f5c3F17261F6F1C4dA058D022BE92776af8"
+ }
+ ],
+ "threshold": 1,
+ "ethBalance": "0"
+ }
+ }
+ },
+ "settings": {
+ "currency": "eur",
+ "tokenList": "TRUSTED",
+ "hiddenTokens": {},
+ "shortName": {
+ "show": false,
+ "copy": false,
+ "qr": false
+ },
+ "theme": {
+ "darkMode": true
+ },
+ "env": {
+ "rpc": {},
+ "tenderly": {
+ "url": "",
+ "accessToken": ""
+ }
+ },
+ "signing": {
+ "onChainSigning": false
+ }
+ },
+ "safeApps": {
+ "5": {
+ "pinned": [
+ 36,
+ 24
+ ]
+ },
+ "100": {
+ "pinned": [
+ 17,
+ 93
+ ]
+ },
+ "137": {
+ "pinned": [
+ 71,
+ 17
+ ]
+ }
+ }
+ }
+}
\ No newline at end of file
diff --git a/cypress/support/commands.js b/cypress/support/commands.js
index 8b059500..75eae8fb 100644
--- a/cypress/support/commands.js
+++ b/cypress/support/commands.js
@@ -5,6 +5,18 @@ Cypress.Commands.add('connectE2EWallet', () => {
})
})
+Cypress.Commands.add('useProdCGW', () => {
+ cy.on('window:before:load', (window) => {
+ window.localStorage.setItem('SAFE_v2__debugProdCgw', JSON.stringify(true))
+ })
+})
+
+Cypress.Commands.add('disableProdCGW', () => {
+ cy.on('window:before:load', (window) => {
+ window.localStorage.setItem('SAFE_v2__debugProdCgw', JSON.stringify(false))
+ })
+})
+
let LOCAL_STORAGE_MEMORY = {}
Cypress.Commands.add('saveLocalStorageCache', () => {
@@ -18,3 +30,49 @@ Cypress.Commands.add('restoreLocalStorageCache', () => {
localStorage.setItem(key, LOCAL_STORAGE_MEMORY[key])
})
})
+
+/**
+ * Wait for a thing by polling for it
+ *
+ * @param {(string|function)} item - A jQuery selector string or a function that returns a boolean
+ * @param {object} [options] - An options object
+ * @param {number} [options.timeout=200] - The time between tries in milliseconds
+ * @param {number} [options.tries=300] - The amount of times to try before failing
+ *
+ * @return {Promise} - A Cypress promise, more at https://docs.cypress.io/api/utilities/promise.html
+ */
+const waitForSelector = (item, options = {}) => {
+ if (typeof item !== 'string' && !(item instanceof Function)) {
+ throw new Error('Cypress plugin waitForSelector: The first parameter should be a string or a function')
+ }
+
+ const defaultSettings = {
+ timeout: 200,
+ tries: 300,
+ }
+ const SETTINGS = { ...defaultSettings, ...options }
+
+ const check = (item) => {
+ if (typeof item === 'string') {
+ return Cypress.$(item).length > 0
+ } else {
+ return item()
+ }
+ }
+
+ return new Cypress.Promise((resolve, reject) => {
+ let index = 0
+ const interval = setInterval(() => {
+ if (check(item)) {
+ clearInterval(interval)
+ resolve()
+ }
+ if (index > SETTINGS.tries) {
+ reject()
+ }
+ index++
+ }, SETTINGS.timeout)
+ })
+}
+
+Cypress.Commands.add('waitForSelector', waitForSelector)
diff --git a/docs/eip-1271.md b/docs/eip-1271.md
deleted file mode 100644
index 0478e1f5..00000000
--- a/docs/eip-1271.md
+++ /dev/null
@@ -1,260 +0,0 @@
-# EIP-1271 Off-Chain signatures
-
-_Note: The current state of the implementation is experimental and subject to change._
-
-The Safe contracts and interface support off chain [EIP-1271](https://eips.ethereum.org/EIPS/eip-1271) signatures.
-But due to Safe being a multisig wallet the flow is slightly different from simple EOA signatures.
-
-This doc explains with examples how to off-chain sign and verify messages.
-All examples will be using [WalletConnect](https://walletconnect.com/) to connect to the Safe and [ethers](https://ethers.io).
-
-## Signing messages
-
-It is possible to sign [EIP-191](https://eips.ethereum.org/EIPS/eip-712) compliant messages as well as [EIP-712](https://eips.ethereum.org/EIPS/eip-191) typed data messages.
-
-### Enabling off-chain signing
-
-Before off-chain signing it was and still is possible to sign messages on-chain. Multiple dApps exist in production which rely on this as the default behavior.
-Therefore to enable off-chain signing it is necessary to send a custom RPC call `safe_setSettings` and pass in
-
-```json
-{
- "offChainSigning": true
-}
-```
-
-to signal that the dApp wants to use off-chain signing.
-
-#### Example: Enable off-chain signing
-
-```ts
-const enableOffChainSigning = async () => {
- const result = await connector.sendCustomRequest({
- method: 'safe_setSettings',
- params: [{ offChainSigning: true }],
- })
-
- if (result?.offChainSigning !== true) {
- throw new Error('Off-chain signing could not be enabled.')
- }
-}
-```
-
-See also [troubleshooting](#off-chain-signing-could-not-be-enabled)
-
-### EIP 191 messages
-
-To sign a message we will have to call the `signMessage` function and pass in the message as hex string.
-
-As meeting the threshold of a Safe message can take quite long, the `signMessage` call will not wait for a message to be fully signed, but instead always return `0x` once the first signature was added.
-
-#### Example: Sign message
-
-```ts
-import { hashMessage, hexlify, toUtf8Bytes } from 'ethers/lib/utils'
-
-const signMessage = async (message: string) => {
- const hexMessage = hexlify(toUtf8Bytes(message))
- await connector.signMessage([safeAddress, hexMessage])
-}
-```
-
-After signing a message it will be available in the Safe's message list (Transactions -> Messages).
-
-### EIP 712 typed data
-
-To sign typed data we will have to call the `signTypedData` function and pass in the typed data object.
-
-As meeting the threshold of a Safe message can take quite long, the `signTypedData` call will not wait for a message to be fully signed, but instead always return `0x` once the first signature was added.
-
-