Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-background-transition not working #922

Open
rleyvasal opened this issue May 13, 2022 · 10 comments
Open

data-background-transition not working #922

rleyvasal opened this issue May 13, 2022 · 10 comments

Comments

@rleyvasal
Copy link

rleyvasal commented May 13, 2022

revealjs example shows how the background transition should work; however, setting the following code in vscode-reveal does not produce the desired effect.

---
theme : "white"
transition: "slide"
slideNumber: false
---

## first slide

---

## second slide

<!-- .slide: data-background="#43464B" data-background-transition="zoom" -->

## Background Transitions

Different background transitions are available via the backgroundTransition option. This one's called "zoom".

@evilz
Copy link
Owner

evilz commented May 18, 2022

do it like this



## first slide

---

<!-- .slide: data-background="#43464B" data-transition="zoom" -->

## second slide

@evilz evilz closed this as completed May 18, 2022
@rleyvasal
Copy link
Author

Thanks, I can confirm it works.

@Sebbstar
Copy link

how can i use different animations for data and the background? Is this already possible by this vscode extension?

<!-- .slide: data-transition="slide" data-background="#4d7e65" data-background-transition="zoom" -->

@evilz
Copy link
Owner

evilz commented Jul 14, 2022

It should works

@Sebbstar
Copy link

Sebbstar commented Jul 15, 2022

can you confirm that this minimal example works for you?
I tested it in multiple browsers and vs code preview window

<!-- .slide: data-transition="slide" data-background="#4d7e65" data-background-transition="zoom" -->

# Page1

---

<!-- .slide: data-transition="slide" data-background="#fd7e65" data-background-transition="slide" -->

## Page2

i'm using
vscode-reveal v4.3.3

Version: 1.70.0-insider (user setup)
Commit: e0a65a97d4f349cf11a7cae804a5553ccb412528
Date: 2022-07-14T05:17:15.290Z
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: 10.0.139.17-electron.0
OS: Windows_NT x64 10.0.22000

also on a clean installation of:
Version: 1.69.1 (user setup)
Commit: b06ae3b2d2dbfe28bca3134cc6be65935cdfea6a
Date: 2022-07-12T08:21:24.514Z
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: 10.0.139.17-electron.0
OS: Windows_NT x64 10.0.22000

data transition are working perfectly. but all background transitions do not work also the parallaxBackground transitions. Using reveal-md the background transitions do work but i would prefer using your extension.

@Sebbstar
Copy link

Sebbstar commented Jul 15, 2022

i tracked the error down to init.js

      const plugins =  [...printPlugins,
      <% if(enableZoom) {%>RevealZoom, <%}%>
      <% if(enableSearch) {%>RevealSearch, <%}%>
          RevealMarkdown, 
          <% if(enableMenu) {%>RevealMenu, <%}%>
          RevealFullscreen,
          RevealAnything,
          //RevealAudioSlideshow,
          //RevealAudioRecorder,
          <% if(enableMenu) {%>RevealCustomControls, <%}%>
          // poll
          // question
          // seminar
          Verticator 
           ]

without the RevealFullscreen plugin background animations are working perfectly.

@evilz
Copy link
Owner

evilz commented Jul 17, 2022

Maybe I should remove this plugin

@rleyvasal
Copy link
Author

Fullscreen plugin is very helpful, if a workaround can be found, it would be preferable

@Sebbstar
Copy link

I tried to modify plugin.js from the fullscreen plugin and disabled line 36 Reveal.configure( config );
The result looks good for me but i am not very family with reeal.js and any of its plugins.

@evilz
Copy link
Owner

evilz commented Jul 18, 2022

Ok issue already exists here rajgoel/reveal.js-plugins#107
It should be fix here.

@evilz evilz reopened this Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants