From 1e97e3e3e3eb451f8254d411fe9cbf8cf993c4da Mon Sep 17 00:00:00 2001 From: minnakt Date: Thu, 20 Mar 2025 11:37:42 -0400 Subject: [PATCH 1/2] DEVPROD-12427: Add test to verify that filters with commas are parsed correctly --- .../cypress/integration/project_filters.ts | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/apps/parsley/cypress/integration/project_filters.ts b/apps/parsley/cypress/integration/project_filters.ts index 5d473b08e1..96c218c398 100644 --- a/apps/parsley/cypress/integration/project_filters.ts +++ b/apps/parsley/cypress/integration/project_filters.ts @@ -31,6 +31,21 @@ describe("project filters", () => { cy.get("[data-cy^='skipped-lines-row-']").should("exist"); }); + it("properly processes filters with commas", () => { + cy.visit(resmokeLogLink); + cy.contains("View project filters").click(); + cy.dataCy("project-filters-modal").should("be.visible"); + cy.getInputByLabel('"Connection accepted","attr"').check({ + force: true, + }); + cy.contains("button", "Apply filters").click(); + cy.location("search").should( + "contain", + "110%2522Connection%2520accepted%2522%252C%2522attr%2522", + ); + cy.get("[data-cy^='skipped-lines-row-']").should("exist"); + }); + it("should disable checkbox if filter is already applied", () => { cy.visit(`${resmokeLogLink}?filters=100D%255Cd`); cy.contains("View project filters").click(); From ce27b86e8c696677477b458f5221f9a4aa955f48 Mon Sep 17 00:00:00 2001 From: minnakt Date: Thu, 20 Mar 2025 18:43:48 -0400 Subject: [PATCH 2/2] Codegen --- apps/parsley/src/gql/generated/types.ts | 3 --- 1 file changed, 3 deletions(-) diff --git a/apps/parsley/src/gql/generated/types.ts b/apps/parsley/src/gql/generated/types.ts index 60418349e0..f3e5bee955 100644 --- a/apps/parsley/src/gql/generated/types.ts +++ b/apps/parsley/src/gql/generated/types.ts @@ -1540,8 +1540,6 @@ export type Notifications = { __typename?: "Notifications"; buildBreak?: Maybe; buildBreakId?: Maybe; - commitQueue?: Maybe; - commitQueueId?: Maybe; patchFinish?: Maybe; patchFinishId?: Maybe; patchFirstFailure?: Maybe; @@ -1554,7 +1552,6 @@ export type Notifications = { export type NotificationsInput = { buildBreak?: InputMaybe; - commitQueue?: InputMaybe; patchFinish?: InputMaybe; patchFirstFailure?: InputMaybe; spawnHostExpiration?: InputMaybe;