Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update evcc.dist.yaml #16720

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Update evcc.dist.yaml #16720

wants to merge 9 commits into from

Conversation

TomF79
Copy link

@TomF79 TomF79 commented Oct 18, 2024

Add some examples for notifications.

Add some examples for notifications.
@andig
Copy link
Member

andig commented Oct 18, 2024

Instead of adding examples- why not just actually use them in the message definitions above?

@TomF79
Copy link
Author

TomF79 commented Oct 18, 2024

Instead of adding examples- why not just actually use them in the message definitions above?

I thought everyone could structure their messages as they wish and let the above as standard.

@andig
Copy link
Member

andig commented Oct 19, 2024

Wir sollten sinnvolle Defaults ausliefern. Da wo es passt kannst Du die gerne mit einbauen. Rest dann raus.

Change standard messages.
@TomF79
Copy link
Author

TomF79 commented Oct 19, 2024

Wir sollten sinnvolle Defaults ausliefern. Da wo es passt kannst Du die gerne mit einbauen. Rest dann raus.

@andig

Hab es nun geändert, somit sind die Aufwendigeren Nachrichten als Standard aufgeführt.

Sieht dann so als Email aus:

Bildschirmfoto 2024-10-19 um 14 09 16 jpeg

Add charge finished title.
@TomF79
Copy link
Author

TomF79 commented Oct 20, 2024

Wir sollten sinnvolle Defaults ausliefern. Da wo es passt kannst Du die gerne mit einbauen. Rest dann raus.

@andig

Nun ok so für Dich?

evcc.dist.yaml Outdated Show resolved Hide resolved
evcc.dist.yaml Outdated Show resolved Hide resolved
@andig
Copy link
Member

andig commented Oct 20, 2024

M.E. gehören keine Leerzeichen zwischen Zahlen und Einheiten.

TomF79 and others added 3 commits October 20, 2024 14:50
Abstand zu Einheiten entfernt.
disconnect: # vehicle connected event
title: Car disconnected
msg: Car disconnected after ${connectedDuration}
soc: # vehicle soc update event
title: Soc updated
msg: Battery charged to ${vehicleSoc:%.0f}%
msg: Battery charged to ${vehicleSoc:%.0f} %
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msg: Battery charged to ${vehicleSoc:%.0f} %
msg: Battery charged to ${vehicleSoc:%.0f}%

@TomF79
Copy link
Author

TomF79 commented Oct 20, 2024

M.E. gehören keine Leerzeichen zwischen Zahlen und Einheiten.

@andig

Leerzeichen entfernt.

evcc.dist.yaml Outdated Show resolved Hide resolved
Add information for costs.
Change message.
@TomF79
Copy link
Author

TomF79 commented Oct 20, 2024

@andig

und so wie jetzt, auskommentiert und mit Info dazu?

@TomF79
Copy link
Author

TomF79 commented Oct 20, 2024

@andig

Einrückung geändert, hoffe jetzt passt es.

@TomF79
Copy link
Author

TomF79 commented Oct 21, 2024

@andig

Fehlt noch etwas, weil ein Check einen Fehler aufweist?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants