Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ocpp: add meterless template #15918

Closed
wants to merge 3 commits into from
Closed

Ocpp: add meterless template #15918

wants to merge 3 commits into from

Conversation

andig
Copy link
Member

@andig andig commented Sep 6, 2024

Fix #15850

@andig andig added the enhancement New feature or request label Sep 6, 2024
@premultiply
Copy link
Member

See #15876 or #15882

@premultiply premultiply marked this pull request as draft September 6, 2024 07:40
@premultiply premultiply added devices Specific device support needs decision Unsure if we should really do this and removed enhancement New feature or request labels Sep 6, 2024
@andig
Copy link
Member Author

andig commented Sep 6, 2024

Kommt aufs gleiche raus. Nur ohne dass man nochmal generell in ocpp meter konfigurieren müsste.

@premultiply
Copy link
Member

Ja, lass uns nochmal abstimmen wie wir am besten vorgehen.
Alle Varianten haben ihre Vor- und Nachteile.

@andig andig marked this pull request as ready for review September 6, 2024 13:49
@premultiply
Copy link
Member

Im Vergleich zu #15876 würde das hier nochmal eine weitere Variante statt dem einfachen Revert des Parameter deprecate aufmachen und unserer Template-Struktur entgegenlaufen. Möglichst nur ein Template pro Hardware, notwendige Einstellungen per Parameter.

@andig
Copy link
Member Author

andig commented Sep 6, 2024

Dann aber bitte erst #15919. Es nervt nämlich ständig ohne Not den Unterschied zwischen type und template erklären zu müssen.

@andig andig closed this Sep 6, 2024
@andig andig deleted the fix/ocpp branch September 6, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devices Specific device support needs decision Unsure if we should really do this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evbox Elvi: set meterValues to empty without meter
2 participants