[Feat] Favorite Posts from Preview Panel #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the preview panel slightly more useful, especially since the heart icon has a hover effect indicating that it should be usable, despite the fact that all it does is send you to the top of the page (Well, at least in firefox) The way I did this is a wee bit hacky, but it works (Well, at least in firefox... Don't see why it wouldn't work in Chrome)... It however doesn't take into account if the user is logged in already or not, but I imagine danbooru will complain bitterly (or stop working) when the user isn't. I would have done the same for the Up / Down vote buttons, however the API doesn't provide that information, even the main posts page waits for you try to up / down vote before offering the chance to remove your vote.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the preview panel slightly more useful, especially since the heart icon has a hover effect indicating that it should be usable, despite the fact that all it does is send you to the top of the page (Well, at least in firefox)
The way I did this is a wee bit hacky, but it works (Well, at least in firefox... Don't see why it wouldn't work in Chrome)... It however doesn't take into account if the user is logged in already or not, but I imagine danbooru will complain bitterly (or stop working) when the user isn't.
I would have done the same for the Up / Down vote buttons, however the API doesn't provide that information, even the main posts page waits for you try to up / down vote before offering the chance to remove your vote.