Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run make regen automatically. #28

Open
schwern opened this issue Nov 25, 2015 · 0 comments
Open

Run make regen automatically. #28

schwern opened this issue Nov 25, 2015 · 0 comments

Comments

@schwern
Copy link
Contributor

schwern commented Nov 25, 2015

It's bad enough that one cannot simply write a C function, you have to add it to embed.fnc, but at least we can make regenerating the headers automatic.

The original rationale for not doing so was because make regen relies on Perl being installed and that can lead you to a weird state if Perl is not already installed or it's broken or it's old. Back in 1997 that could happen. Here in 2015 it's pretty unlikely.

It also comes from the POV that only a few people will be working on the Perl core and only occasionally writing new functions. We encourage lots of people to work on the Perl core and to write lots of new, small functions.

This will probably involve adding targets to the Makefile for each generated header file so that it runs its appropriate script in regen/ .. What is built by each script can be found by grep -r 'This file is built by .*blah.pl' .. The dependencies will require reading through each regen script. Usually you can just look for the open statements. For example...

opcode.h opnames.h lib/B/Op_private.pm pp_proto.h: regen/opcodes 
    -perl regen/opcode.pl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant