You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, we use some functions from rlang that are marked as internal but still exported (message_cnd(), error_cnd()). It is not entirely clear to me what this means. Here is what https://r-pkgs.org/ says about it:
Generally, keywords are not that useful except for @Keywords internal. Using the internal keyword removes the function from the package index and disables some of its automated tests. It’s common to use @Keywords internal for functions that are of interest to other developers extending your package, but not most users.
Does this mean their use is discouraged in our case?
At the moment, we don't rely use the fact that objects of class fhub_validations are a list of conditions. We could easily design it as a list of other S3 objects.
The only other rlang function we use is format_error_bullets() and it could be replace by the equivalent cli::cli_bullets().
The text was updated successfully, but these errors were encountered:
Currently, we use some functions from rlang that are marked as
internal
but still exported (message_cnd()
,error_cnd()
). It is not entirely clear to me what this means. Here is what https://r-pkgs.org/ says about it:Does this mean their use is discouraged in our case?
At the moment, we don't rely use the fact that objects of class
fhub_validations
are a list of conditions. We could easily design it as a list of other S3 objects.The only other rlang function we use is
format_error_bullets()
and it could be replace by the equivalentcli::cli_bullets()
.The text was updated successfully, but these errors were encountered: