Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from rlang? #4

Open
Bisaloo opened this issue Aug 23, 2021 · 0 comments
Open

Move away from rlang? #4

Bisaloo opened this issue Aug 23, 2021 · 0 comments
Labels
question Further information is requested

Comments

@Bisaloo
Copy link
Member

Bisaloo commented Aug 23, 2021

Currently, we use some functions from rlang that are marked as internal but still exported (message_cnd(), error_cnd()). It is not entirely clear to me what this means. Here is what https://r-pkgs.org/ says about it:

Generally, keywords are not that useful except for @Keywords internal. Using the internal keyword removes the function from the package index and disables some of its automated tests. It’s common to use @Keywords internal for functions that are of interest to other developers extending your package, but not most users.

Does this mean their use is discouraged in our case?

At the moment, we don't rely use the fact that objects of class fhub_validations are a list of conditions. We could easily design it as a list of other S3 objects.

The only other rlang function we use is format_error_bullets() and it could be replace by the equivalent cli::cli_bullets().

@Bisaloo Bisaloo added the question Further information is requested label Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant