Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segment kinds #21

Open
bjorn-stevens opened this issue Mar 27, 2021 · 1 comment
Open

Segment kinds #21

bjorn-stevens opened this issue Mar 27, 2021 · 1 comment

Comments

@bjorn-stevens
Copy link

Would it be possible to rename the radar_calibration_wiggles rather radar_calibration_roll, and radar_calibration_tilted rather radar_calibratio_pearl. There reason is that the former is a roll maneuver, this is also common for calibrating the gust probes, and I would actually simply call this a roll maneuver. The pearl is short circle, sometimes longer, and is a meaningful maneuver even if not calibrating the radar. For tis reason one could be a bit more general and say: pearl, and roll maneuvers.

@d70-t
Copy link
Collaborator

d70-t commented Apr 5, 2021

I'd recommend not to do this. The kinds are a form of identifier and are likely used at some places already (i.e. for seraching for the respective segments). If we'd remove any kinds from existing, published segments, we might break some existing code.

We probably could add your suggested kinds as additional kinds to the existing segments. That should be backwards-compatible. We could then mark the old kinds as deprecated in the readme, such that people should prefer to use the new kinds in future. If we do this, we should probably think a bit and broadly agree on which common kind names we really like to have. Another option would be to keep both. I.e. to have radar_calibration_wiggles for those specific maneuvers and a more generic roll_maneuver which could be applied to all radar_calibration_wiggles as well as to other, non-radar specific roll_maneuvers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants