When used as mediawiki widget, Safari browser shown fallback code requesting to download flash player ...

[johnnyBrandom]

Note that this project is being used as a mediawiki widget for playing audio files. See here for background:

https://www.mediawikiwidgets.org/Html5mediaAudio

Unfortunately, in some cases, this code is resulting in problems for Safari browser (mobile and desktop). Problem manifests as a poorly formatted notice stating that Flash 9.0 or greater is required along with a link to adobe to download flashplayer (see attached screen grab). The issue appears to be triggering perhaps outdated fallback code in this software. Should this fallback code be revised to remove references to flash? As is, fallback code appears to present similarly to adware injection malware (although the link does direct to adobe).

For demonstration of undesired behavior - please visit following mediawiki sandbox page using Safari browser (mobile or desktop):

https://sandbox.semantic-mediawiki.org/wiki/Embed_audio_files

It is unclear specifically what the issue is but the browser console shows following warnings:

[Log] JQMIGRATE: Migrate is installed with logging active, version 3.0.1 (load.php, line 141)
[Warning] This page is using the deprecated ResourceLoader module "jquery.tabIndex". (Embed_audio_files, line 280)
[Warning] JQMIGRATE: jQuery.fn.delegate() is deprecated (load.php, line 141)
[Warning] JQMIGRATE: jQuery.fn.bind() is deprecated (load.php, line 141)

Thank you. Hopefully this can be repaired as this is a very useful project.

[etianen]

Thanks for reporting this. This is a tricky problem. The whole point of this project is to detect whether the browser supports the given audio/video tag, and if it does not, replace the audio/video tag with a Flash fallback. In the days when html5 audio/video tag support was rare, and Flash was common, this made a whole lot of sense. Nowadays, Flash is not supported in a lot of browsers, and html5 video/audio tags are supported almost everywhere. I'm really confused about why Safari is trying to trigger the Flash fallback. It supports MP4 files, certainly. I think it's worth asking whether it's worth using this shim at all. HTML5 audio/video tags are supported in IE9+. Do you really want to be using a shim to support IE8 at this point, when the shim is leading to problems in Safari? I'd say no, at this point. If you still wish to support IE8 or below, you'll need to figure out how to fix the Safari problem without breaking other browsers. You'll need to find a way to test it on IE8 too. Since I no longer have a machine capable of running IE8 or Safari, there's not a whole lot I can do here myself. I'll take and review a merge request, no worries, and will happily update the CDN with a new release.

…

On Fri, 24 Jul 2020 at 05:14, johnnyBrandom ***@***.***> wrote: Note that this project is being used as a mediawiki widget for playing audio files. See here for background: https://www.mediawikiwidgets.org/Html5mediaAudio <http://url> Unfortunately, in some cases, this code is resulting in problems for Safari browser (mobile and desktop). Problem manifests as a poorly formatted notice stating that Flash 9.0 or greater is required along with a link to adobe to download flashplayer (see attached screen grab). The issue appears to be triggering perhaps outdated fallback code in this software. Should this fallback code be revised to remove references to flash? As is, fallback code appears to present similarly to adware injection malware (although the link does direct to adobe). For demonstration of undesired behavior - please visit following mediawiki sandbox page using Safari browser (mobile or desktop): https://sandbox.semantic-mediawiki.org/wiki/Embed_audio_files <http://url> It is unclear specifically what the issue is but the browser console shows following warnings: [Log] JQMIGRATE: Migrate is installed with logging active, version 3.0.1 (load.php, line 141) [Warning] This page is using the deprecated ResourceLoader module "jquery.tabIndex". (Embed_audio_files, line 280) [Warning] JQMIGRATE: jQuery.fn.delegate() is deprecated (load.php, line 141) [Warning] JQMIGRATE: jQuery.fn.bind() is deprecated (load.php, line 141) Thank you. Hopefully this can be repaired as this is a very useful project. [image: Screen Shot 2020-07-23 at 11 45 20 AM] <https://user-images.githubusercontent.com/42355639/88359896-5670f380-cd42-11ea-8cd2-8389b7741b0c.png> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#82>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABEKCDYUKG6USDJZ2TLBE3R5EDCRANCNFSM4PGLGJ7Q> .

[johnnyBrandom]

Thanks for responding. After taking time to review the circumstances of this issue, I agree with your position. As for my reason for using your project, I actually don't need to support IE8, rather I need a way to insert html media tags into mediawiki. In general, html in mediawiki is not permitted, however they offer several means to add html for those who need it in their wiki. Examining the options (none of which seemed great), I selected the mediawikiwidget method, which is one of the options they advertise on the mediawiki site. In that project, another nice developer used this project (html5media) as the means to enable html5 media tags. However, discovering this issue has prompted me to looked over the mediawikiwidget project in greater detail. I now see that it is a project outside of the mediawiki umbrella, and lacks a robust support model (not because of your response - I agree you are not obligated to support their effort). I also have doubts about mediawiki adopting and supporting the mediwikiwidget effort internally. It just doesn't seem likely. Therefore, I think my best path is to go with one of the other options they offer. Thanks again for the generosity of your time and software!

edit: BTW - just for the sake of completeness, I think this particular issue with Safari is that it does not support the .ogg media format which was used in the sandbox example above. I believe this is what is causing the fallback code to execute. It works fine for media formats that Safari does support internally.

[etianen]

That sounds a sensible approach. Happy coding. :)

…

On Sat, 25 Jul 2020 at 06:00, johnnyBrandom ***@***.***> wrote: Thanks for responding. After taking time to review the circumstances of this issue, I agree with your position. As for my reason for using your project, I actually don't need to support IE8, rather I need a way to insert html media tags into mediawiki. In general, html in mediawiki is not permitted, however they offer several means to add html for those who need it in their wiki. Examining the options (none of which seemed great), I selected the mediawikiwidget method, which is one of the options they advertise on the mediawiki site. In that project, another nice developer used this project (html5media) as the means to enable html5 media tags. However, discovering this issue has prompted me to looked over the mediawikiwidget project in greater detail. I now see that it is a project outside of the mediawiki umbrella, and lacks a robust support model (not because of your response - I agree you are not obligated to support their effort). I also have doubts about mediawiki adopting and supporting the mediwikiwidget effort internally. It just doesn't seem likely. Therefore, I think my best path is to go with one of the other options they offer. Thanks again for the generosity of your time and software! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#82 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABEKCGV7ORT5IWQQX4EHCDR5JRG7ANCNFSM4PGLGJ7Q> .