Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not work when height and width set to percentage #58

Open
adayan opened this issue Jan 20, 2015 · 3 comments
Open

Not work when height and width set to percentage #58

adayan opened this issue Jan 20, 2015 · 3 comments

Comments

@adayan
Copy link

adayan commented Jan 20, 2015

Hi,

When I set width and height to video use percentage, Firefox and ie8 cannot show the video, it seems that getDimension method count incorrectly when the attributes with '%', eg. height='30%'. Is there any solution for this problem?

Thanks

@etianen
Copy link
Owner

etianen commented Jan 20, 2015

The width and height attributes of a video need to be specified in pixels. Specifying them as percentages is not supported at this time.

On 20 Jan 2015, at 01:31, adayan [email protected] wrote:

Hi,

When I set width and height to video use percentage, Firefox and ie8 cannot show the video, it seems that getDimension method count incorrectly when the attributes with '%', eg. height='30%'. Is there any solution for this problem?

Thanks


Reply to this email directly or view it on GitHub.

@Ghostavio
Copy link

Any plans to add percentage support?

@Ghostavio
Copy link

btw, here's a workaround (add this to your css):
.video-wrapper span { height: 100% !important; }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants