Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

PTAM initialisation bug #70

Open
vixtor-qm opened this issue Jun 18, 2015 · 2 comments
Open

PTAM initialisation bug #70

vixtor-qm opened this issue Jun 18, 2015 · 2 comments

Comments

@vixtor-qm
Copy link

HI, i found a bug in original and your PTAM code.
bug is related to map initialisation
here it is:

line362: p->RefreshPixelVectors();
At this moment p->worldPosition is not set, therefore pixel vectors will get arbitrary values.
this then prevents
finder.SetSubPixPos(vec(vTrailMatches[i].second));
bool bGood = finder.IterateSubPixToConvergence(*pkSecond,10);
to find matches.

@simonlynen
Copy link
Contributor

Can you make a pull request for this change? Then I am happy to take a look
at it. Thanks
On Jun 18, 2015 8:19 PM, "vixtor-qm" [email protected] wrote:

HI, i found a bug in original and your PTAM code.
bug is related to map initialisation
here it is:

line362: p->RefreshPixelVectors();
At this moment p->worldPosition is not set, therefore pixel vectors will
get arbitrary values.
this then prevents
finder.SetSubPixPos(vec(vTrailMatches[i].second));
bool bGood = finder.IterateSubPixToConvergence(*pkSecond,10);
to find matches.


Reply to this email directly or view it on GitHub
#70.

@vixtor-qm
Copy link
Author

yes, sure. can't do right now, will do tomorrow morning

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants