Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin UI: support new TCF related fields on System model #4248

Closed
adamsachs opened this issue Oct 10, 2023 · 0 comments
Closed

admin UI: support new TCF related fields on System model #4248

adamsachs opened this issue Oct 10, 2023 · 0 comments
Assignees

Comments

@adamsachs
Copy link
Contributor

adamsachs commented Oct 10, 2023

Is your feature request related to a specific problem?

Admin UI support for fields added in #4227, #4245 - expose them in edit/view forms for systems.

System fields:

  • cookie_max_age_seconds: Optional[int]
  • uses_cookies: bool, default=False
  • cookie_refresh: bool, default=False
  • uses_non_cookie_access: bool, default=False
  • legitimate_interest_disclosure_url: Optional[str]

PrivacyDeclaration fields:

  • flexible_legal_basis_for_processing: Optional[bool] -- don't default to anything if Compass gives you null/None update here @TheAndrewJackson Compass isn't really capable of giving you a null/None for this field, i don't think, so i'd ignore any special handling for now, please treat this as a normal boolean! we probably need to revisit this a bit from the BE/data modeling POV across the stack, but i don't think there's any need to go out of your way in the FE code for now 👍

Describe the solution you'd like

These fields should show up in the System and PrivacyDeclaration forms, and they should also get populated from Compass, which will now be serving them as fields in its response

Describe alternatives you've considered, if any

Need to look further into Optional[bool] to see if this is really viable...

Additional context

https://ethyca.atlassian.net/browse/PROD-1147

https://github.com/ethyca/fides/issues/4269 is a followup that covers the flexible logic for legal basis, which is not being done as part of the current unit of work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants