Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gift card fund hexlify issue with xDAI transfer #595

Open
Cafe137 opened this issue Nov 30, 2022 · 0 comments
Open

Gift card fund hexlify issue with xDAI transfer #595

Cafe137 opened this issue Nov 30, 2022 · 0 comments

Comments

@Cafe137
Copy link
Collaborator

Cafe137 commented Nov 30, 2022

Our Rpc.sendNativeTransaction implementation needs a string for the value of the transaction.

This was this.dai.toBigNumber.minus(totalCost.toString()).toString() before. I tried out the gift card fund feature with the fake-bee and even though it is a mock environment, I ran into an issue which seemed to be client side only in Bee Dashboard.

This string is provided wrongly, and the correct expression may be '0x' + this.dai.toBigNumber.minus(totalCost.toString()).toString(16), that is hexademical and leading 0x (ethers hexlify).

This should be investigated with a proper mainnet gift card fund manual test. BTW I attempted to transfer 13.9529 xDAI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant