Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo on the transactionReceipt.gasPrice field: "caluclated" should be "calculated" #4390

Open
flanagansteve opened this issue Sep 25, 2023 · 0 comments · May be fixed by #4919
Open

Typo on the transactionReceipt.gasPrice field: "caluclated" should be "calculated" #4390

flanagansteve opened this issue Sep 25, 2023 · 0 comments · May be fixed by #4919
Labels
documentation Documentation related issue.

Comments

@flanagansteve
Copy link

Suggestion

In the description of transactionReceipt.gasPrice, it says:

"Due to the complexity of EIP-1559 this value can only be caluclated after the transaction has been mined, snce the base fee is protocol-enforced."

"caluclated" should be "calculated".

You can find all three instances of the typo in the codebase using this search: https://github.com/search?q=repo%3Aethers-io%2Fethers.js%20caluclated&type=code
@flanagansteve flanagansteve added the documentation Documentation related issue. label Sep 25, 2023
jorsema2 added a commit to jorsema2/ethers.js that referenced this issue Jan 15, 2025
@jorsema2
docs: fixed typo in transactionReceipt.gasPrice description (ethers-i…
320c392 
…o#4390)
jorsema2 added a commit to jorsema2/ethers.js that referenced this issue Jan 15, 2025
@jorsema2
docs: fixed typo in transactionReceipt.gasPrice description (ethers-i…
590dcff 
…o#4390)
@jorsema2 jorsema2 linked a pull request Jan 15, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Documentation related issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: fixed typo in transactionReceipt.gasPrice description (#4390) jorsema2/ethers.js
1 participant
@flanagansteve