Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SSZ Union from BlockHeaderWithProof container type #722

Closed
4 tasks
acolytec3 opened this issue Jan 27, 2025 · 0 comments · Fixed by #725
Closed
4 tasks

Remove SSZ Union from BlockHeaderWithProof container type #722

acolytec3 opened this issue Jan 27, 2025 · 0 comments · Fixed by #725

Comments

@acolytec3
Copy link
Collaborator

Following this, it is likely we will need to remove BlockHeaderProofType union type and replace it with a simple ByteList.

This is roughly our todo list

  • - remove BlockHeaderProofType and replace with a Bytelist with a MAX_PROOF_SIZE as defined in the spec
  • - Switch logic in all of the header proof serializing/deserializing code in src/networks/history.ts to select the proof type based on the timestamp embedded in the block header
  • - Create an enum containing the hardfork timestamps for Bellatrix and Capella so we use the right proof types
  • - Update all the tests and test with the new test vectors from the above linked PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant