You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Now that there are more audited versions of the staking-deposit-cli, it is time to rethink how we do ensure that the deposit_data.json was generated by a tool with sufficient features.
Currently, we use the REACT_APP_MIN_DEPOSIT_CLI_VERSION constant to ensure a minimum feature set, but this is awkwardly tied to the https://github.com/ethereum/staking-deposit-cli which noi longer seems appropriate.
One approach would be to have text-based features we add to ensure a minimum level of support and check for those (eg. testnet-holesky, bug-fix-123), but this feels a little over engineered for our current needs.
Personally I am partial to sticking with the numbering approach, but just agreeing with the ethstaker folks as to when we need to bump the version number. We could even maintain a doc in this repo that maps features to version numbers.
EthStaker and other potential tools can have a unique field that would define the necessary version for that tool. IE instead of using deposit_cli_version we could use ethstaker_cli_version. Updating DepositKeyInterface and then making use of that optional field would be a pretty trivial change and easy to maintain for future versioning updates.
Similar to what you suggested we can add a field that defines an array of feature flags that can be utilized in the launchpad. I do agree with you though that this seems a bit much for where we are now
We can always discuss the potential of removing this check entirely given the ease of spoofing.
Now that there are more audited versions of the staking-deposit-cli, it is time to rethink how we do ensure that the
deposit_data.json
was generated by a tool with sufficient features.Currently, we use the
REACT_APP_MIN_DEPOSIT_CLI_VERSION
constant to ensure a minimum feature set, but this is awkwardly tied to the https://github.com/ethereum/staking-deposit-cli which noi longer seems appropriate.One approach would be to have text-based features we add to ensure a minimum level of support and check for those (eg.
testnet-holesky, bug-fix-123
), but this feels a little over engineered for our current needs.Personally I am partial to sticking with the numbering approach, but just agreeing with the ethstaker folks as to when we need to bump the version number. We could even maintain a doc in this repo that maps features to version numbers.
cc @remyroy @valefar-on-discord I'd love to hear your thoughts here.
The text was updated successfully, but these errors were encountered: