Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate MIN_DEPOSIT_CLI_VERSION validation from deposit data validation #605

Open
hwwhww opened this issue Feb 23, 2023 · 0 comments
Open

Comments

@hwwhww
Copy link
Contributor

hwwhww commented Feb 23, 2023

To address #532

Reporting by @barnabasbusa

When using older deposit-cli version that less than MIN_DEPOSIT_CLI_VERSION, the error message is confusing

image

The MIN_DEPOSIT_CLI_VERSION validation should be handled separately from deposit data validation:

// check the deposit-cli version
if (
compareVersions.compare(
depositDatum.deposit_cli_version,
MIN_DEPOSIT_CLI_VERSION,
'<'
)
) {
return false;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant