-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the new tables sources
and compiled_contracts_sources
#1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
marcocastignoli
changed the title
Add support for the new tables
Add support for the new tables Sep 18, 2024
source_codes
and `compiled_contracts…source_codes
and compiled_contracts_sources
marcocastignoli
commented
Sep 19, 2024
marcocastignoli
changed the title
Add support for the new tables
Add support for the new tables Sep 19, 2024
source_codes
and compiled_contracts_sources
sources
and compiled_contracts_sources
manuelwedler
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1614
This PR also implement the execution of insert and update queries inside an SQL transaction. I included also two tests (one for insert, one for update) to check if the database doesn't change after a failed transaction. The insert/update of the
sourcify_matches
table is not included in the transaction because it is executed only if averified_contracts
is successfully created or updated.