Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the new tables sources and compiled_contracts_sources #1615

Merged
merged 11 commits into from
Sep 30, 2024

Conversation

marcocastignoli
Copy link
Member

@marcocastignoli marcocastignoli commented Sep 4, 2024

See #1614

This PR also implement the execution of insert and update queries inside an SQL transaction. I included also two tests (one for insert, one for update) to check if the database doesn't change after a failed transaction. The insert/update of the sourcify_matches table is not included in the transaction because it is executed only if a verified_contracts is successfully created or updated.

@kuzdogan kuzdogan mentioned this pull request Sep 13, 2024
1 task
@marcocastignoli marcocastignoli changed the title Add support for the new tables source_codes and `compiled_contracts… Add support for the new tables source_codes and compiled_contracts_sources Sep 18, 2024
@marcocastignoli marcocastignoli marked this pull request as ready for review September 19, 2024 08:16
@manuelwedler manuelwedler self-assigned this Sep 19, 2024
@marcocastignoli marcocastignoli changed the title Add support for the new tables source_codes and compiled_contracts_sources Add support for the new tables sources and compiled_contracts_sources Sep 19, 2024
Copy link
Collaborator

@manuelwedler manuelwedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@marcocastignoli marcocastignoli merged commit 2397f8c into staging Sep 30, 2024
6 checks passed
@marcocastignoli marcocastignoli deleted the source-codes-table branch September 30, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

Support for the new tables source_codes and compiled_contracts_sources
2 participants