Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement retry mechanism for fetching of contract creation tx #1480

Open
manuelwedler opened this issue Jul 16, 2024 · 0 comments
Open

Implement retry mechanism for fetching of contract creation tx #1480

manuelwedler opened this issue Jul 16, 2024 · 0 comments

Comments

@manuelwedler
Copy link
Collaborator

From time to time, we have failing tests for fetching the contract creation transaction from etherscan. The Etherscan API is just some times inaccessible. Here is an example for a failing CI: https://app.circleci.com/pipelines/github/ethereum/sourcify/6426/workflows/1bee0997-2d25-4bd9-98fa-13f64ca43d35/jobs/38746

I propose to implement a retry mechanism for fetching the creation transaction. In case an API is simply unavailable for a short time, retrials can make the verification more stable. Retrials with exponential backoff are usually a good idea to not run into rate limiting again and again (here is an example for this technique).

@ethereum ethereum deleted a comment from Spire83 Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant